Skip to content

Corrected helper text link color #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivasankaran18
Copy link

Closes #334

This PR fixes the issue where the Template Playground link inside the HelperText component had inconsistent colors across dark and light themes. The link now properly retains its cyan (#19c6c7) color in both themes.

Changes

  • Fixed link color by explicitly setting color: #19c6c7 !important; to override inherited styles.
  • Ensured that dark mode does not override the link color.

Flags

  • Verify that no global CSS overrides are affecting the link styles.
  • Ensure the cyan color remains visible in both themes with accessibility in mind.

Screenshots or Video

Fixed Appearance

Screenshot 2025-03-28 031247
Screenshot 2025-03-28 031259

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests.
  • Commit messages follow AP format.
  • Extend the documentation, if necessary.
  • Merging to main from fork:branchname.

@shivasankaran18 shivasankaran18 requested a review from a team as a code owner March 27, 2025 21:51
Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 20101cb
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67e5c8772c270c0007010f11
😎 Deploy Preview https://deploy-preview-335--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivasankaran18
Copy link
Author

@DianaLease could you review this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Link Color in HelperText Component (Dark/Light Mode Issue)
1 participant