Fix CI/CD failures: Remove unused import and replace retry-action#3
Merged
Merged
Conversation
…t.ts Co-authored-by: acoyfellow <1666099+acoyfellow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix import issue in src/container-client.ts
Remove unused @cloudflare/containers import causing test failures
Jan 19, 2026
Owner
|
@copilot can you see the errors? i'd like you to ffix them please |
The CI workflow was failing because it used nick-fields/retry-action@v2, which GitHub cannot resolve. Replaced all three usages with native bash retry loops that: - Use simple for loops with configurable MAX_ATTEMPTS and RETRY_DELAY - Provide clear logging of each attempt - Sleep between retries with countdown - Exit with proper status codes This removes dependency on third-party actions and makes the workflow more reliable. Co-authored-by: acoyfellow <1666099+acoyfellow@users.noreply.github.com>
Contributor
Author
Fixed in commit 6f51ab9. The CI was failing because the workflow used I replaced all three retry-action usages with native bash retry loops that are more reliable and don't depend on third-party actions. The new implementation:
The workflow should now run successfully. |
Copilot
AI
changed the title
Remove unused @cloudflare/containers import causing test failures
Fix CI/CD failures: Remove unused import and replace retry-action
Jan 19, 2026
Deployment StatusStage: pr-3 Ralph Loop completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests were failing due to two issues:
Import Issue:
src/container-client.tshad a top-level import of@cloudflare/containers, which attempts to resolve thecloudflare:workersruntime dependency even in test environments where it's unavailable.Workflow Issue: CI workflow used
nick-fields/retry-action@v2which GitHub couldn't resolve (repository not found), causing all workflow runs to fail immediately.Changes
Container Client Fix
import { Container } from "@cloudflare/containers"Containertype was never referenced in the fileconst { getContainer, switchPort } = await import("@cloudflare/containers")The dynamic import loads the module only when the production code path executes (Cloudflare Container binding), avoiding dependency resolution during test execution.
CI Workflow Fix
nick-fields/retry-action@v2with native bash retry loopsThe native bash implementation provides the same retry functionality with better logging and no dependency on third-party actions.
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.