chore: Remove createMapWithDefault utility #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasHaimerl
requested review from
amateima,
ashwinrava,
dohaki,
melisaguevara,
mrice32 and
nicholaspai
as code owners
amateima
reviewed
Nov 19, 2025
Comment on lines
28
to
42
|
|
||
| export const isTestnet = (chainId: number): boolean => { | ||
| return ( | ||
| chainId === CHAIN_IDs.ARBITRUM_SEPOLIA || | ||
| chainId === CHAIN_IDs.HYPEREVM_TESTNET || | ||
| chainId === CHAIN_IDs.BASE_SEPOLIA || | ||
| chainId === CHAIN_IDs.BLAST_SEPOLIA || | ||
| chainId === CHAIN_IDs.LISK_SEPOLIA || | ||
| chainId === CHAIN_IDs.MODE_SEPOLIA || | ||
| chainId === CHAIN_IDs.OPTIMISM_SEPOLIA || | ||
| chainId === CHAIN_IDs.POLYGON_AMOY || | ||
| chainId === CHAIN_IDs.SEPOLIA || | ||
| chainId === CHAIN_IDs.SOLANA_DEVNET | ||
| ); | ||
| }; |
Contributor
There was a problem hiding this comment.
I think some of these mappings/definitions are already in the constants package and the check can be reduced to smth like
import {
PRODUCTION_NETWORKS,
TEST_NETWORKS,
} from "@across-protocol/constants";
const isMainnet = chainId in PRODUCTION_NETWORKS
const isTestnet = chainId in TEST_NETWORKS
Contributor
Author
There was a problem hiding this comment.
Great point, thanks.
I'll make that change
…ross-protocol/constants
amateima
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/uma/issue/ACB-16/remove-default-mapping