-
Notifications
You must be signed in to change notification settings - Fork 2
feat: track simple transfer completed oft #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nikolas/track-FallbackHyperEVMFlowCompleted
Are you sure you want to change the base?
feat: track simple transfer completed oft #433
Conversation
…d utility Move SimpleTransferFlowCompleted event processing logic from CctpRepository to a shared hyperEvmExecutor utility module. Add support for tracking these events in OFT indexer by fetching ComposeDelivered events and extracting SimpleTransferFlowCompleted events from transaction receipts. Update method signatures to use block
…leTransferCompleted-OFT
| * The unique keys to check for. It is recommended these keys to be indexed columns, so that the query is faster. | ||
| * @param comparisonKeys - The keys to compare for changes. | ||
| */ | ||
| protected async saveAndHandleFinalisationBatch<Entity extends ObjectLiteral>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need this function to be able to share the storing function for Simple transfers for OFT and CCTP, see https://github.com/across-protocol/indexer/pull/433/files#diff-103d64d5e62515d16ca06086549eabe7dbc05b089ad0c69d013da5fc23918d84R52
…leTransferCompleted-OFT
…leTransferCompleted-OFT
…backHyperEVMFlowCompleted
…as/track-SimpleTransferCompleted-OFT
cec1bb8 to
8ba3d4e
Compare
…as/track-SimpleTransferCompleted-OFT
| // Taken from https://hyperevmscan.io/address/0x2beF20D17a17f6903017d27D1A35CC9Dc72b0888#code | ||
| [CHAIN_IDs.HYPEREVM]: "0x2beF20D17a17f6903017d27D1A35CC9Dc72b0888", | ||
| }; | ||
| (""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 2b99900
| const composeDeliveredEvents = await fetchEvents( | ||
| this.provider, | ||
| ENDPOINT_V2_ADDRESS, | ||
| "event ComposeDelivered(address from, address to, bytes32 guid, uint16 index)", | ||
| blockRange.from, | ||
| blockRange.to, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this getLogs() RPC call be made only if chainId is HyperEVM (either mainnet or testnet)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 2b99900
Adds tracking for SimpleTransferCompletedEvents for OFT.
Useful links: https://hyperevmscan.io/tx/0xf72cfb2c0a9f781057cd4f7beca6fc6bd9290f1d73adef1142b8ac1b0ed7186c#eventlog#36