Skip to content

Non-role input types require an accessible name #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Non-role input types require an accessible name #2228

wants to merge 8 commits into from

Conversation

@WilcoFiers
Copy link
Member

@WilcoFiers WilcoFiers commented Nov 21, 2024

Noticed this when reviewing the form control rule. I think we need to do the same for the Form field label is descriptive rule. Leaving this as a draft PR until then.

Need for Call for Review: 1 week

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77
Copy link
Collaborator

Jym77 commented Dec 19, 2024

Closes #2123.

Jym77
Jym77 previously requested changes Dec 19, 2024
View reviewed changes
@giacomo-petri
Copy link
Collaborator

giacomo-petri commented Dec 19, 2024

Already approving. Good catch @Jym77

@carlosapaduarte carlosapaduarte requested a review from Jym77 February 6, 2025 13:17
Jym77
Jym77 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvement on the background note.

@zlayaAvocado zlayaAvocado self-assigned this Jul 11, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025 •
edited
Loading

✅ Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit d3dfb87
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/69263068ae0aab00083ef885
😎 Deploy Preview https://deploy-preview-2228--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zlayaAvocado zlayaAvocado marked this pull request as ready for review November 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

@Jym77 Jym77 Jym77 approved these changes

@giacomo-petri giacomo-petri giacomo-petri approved these changes

Assignees

@zlayaAvocado zlayaAvocado

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WilcoFiers @Jym77 @giacomo-petri @carlosapaduarte @zlayaAvocado