Split ARIA props not prohibited from ARIA props permitted #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
carlosapaduarte
added
Rule
shunguoy
approved these changes
Sep 4, 2025
WilcoFiers
commented
Oct 2, 2025
WilcoFiers
commented
Oct 2, 2025
zlayaAvocado
previously requested changes
Oct 2, 2025
Comment on lines
+140
to
+144
| The `aria-brailleroledescription` property is [prohibited][] for an element with a `none` role. | ||
|
|
||
| ```html | ||
| <h1 role="none" aria-brailleroledescription="Banana text">I like bananas</h1> | ||
| ``` |
There was a problem hiding this comment.
do you think this could be replaced by role="presentation"? it would be clearer because I had to search that role="none" is just a synonym to that
There was a problem hiding this comment.
Discussed on the call. "none" tends to be the preferred name for this these days.
carlosapaduarte
previously requested changes
Oct 2, 2025
| ## Background | ||
|
|
||
| The presence of prohibited ARIA attributes is often the result of a developer using an incorrect role, or a misunderstanding of the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that a state or property which should exist is missing. | ||
| The use of ARIA attributes that are not supported by a role is often the result of a developer either an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users. |
There was a problem hiding this comment.
Suggested change
| The use of ARIA attributes that are not supported by a role is often the result of a developer either an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users. | |
| The use of ARIA attributes that are not supported by a role is often the result of a developer either using an incorrect role, or misunderstanding the attribute. These attributes are ignored by browsers and other assistive technologies. This often means that information that should exist is missing to assistive technology users. |
|
|
||
| ## Expectation | ||
|
|
||
| No test target is [prohibited][] on the [semantic role][] of the element on which it is specified. |
There was a problem hiding this comment.
Suggested change
| No test target is [prohibited][] on the [semantic role][] of the element on which it is specified. | |
| The test target is not [prohibited][] on the [semantic role][] of the element on which it is specified. |
dan-tripp-siteimprove
approved these changes
Oct 2, 2025
| - JFK's "We Choose the Moon" speech excerpt is courtesy of NASA. | ||
| --- | ||
|
|
||
| ## Applicability |
There was a problem hiding this comment.
Maybe a nitpick: I would feel better if the word "attribute" was mentioned here (in the applicability). This would match other rules such as https://www.w3.org/WAI/standards-guidelines/act/rules/5f99a7/ , https://www.w3.org/WAI/standards-guidelines/act/rules/6a7281/ , https://www.w3.org/WAI/standards-guidelines/act/rules/674b10/ .
There was a problem hiding this comment.
This comment also applies to the other rule.
Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Aleksandra <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
WilcoFiers
dismissed stale reviews from zlayaAvocado and carlosapaduarte
Accepted
colabottles
approved these changes
Oct 9, 2025
sage-putnam
approved these changes
Oct 9, 2025
WilcoFiers
added
the
Review call 2 weeks
carlosapaduarte
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress...
Closes issue(s):
Need for Call for Review: 2 weeks
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve