-
Notifications
You must be signed in to change notification settings - Fork 78
Resolution for Passed Example 3 in "Headers attribute specified on a cell refers to cells in the same table element" [a25f45] #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ell refers to cells in the same table element [a25f45] - Added accessibility supported note - Added clarification that passed example 3 is not meeting ARIA in HTML and HTML specs
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
#### Passed Example 3 | ||
|
||
The `headers` attribute on the data cells in the second row refers to a `td` element with a role of `columnheader` within the same `table`. | ||
Although this construct does not conform to the [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-td) or [HTML specifications](https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements), it behaves the same as using a `th` element instead of a `td` element with a role of `columnheader`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this construct does not conform to the [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-td) or [HTML specifications](https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements), it behaves the same as using a `th` element instead of a `td` element with a role of `columnheader`. | |
Although this construct does not conform to the [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-td) or [HTML specifications](https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements), it behaves the same as using a `th` element instead of a `td` element with a role of `columnheader`, on all popular browser / screen reader combinations, at the time of writing. |
^^ because I think it would be valuable to note somehow that this is a snapshot in time, based on some (great!) testing that you did, and the behaviour could change. It's like an "Accessibility Support Note" for this example.
Also I wonder if it's worth linking to your test table. That would help future archeologists. And maybe even spell out the fact that your statement above ("it behaves the same...") was derived from the observation that in your test table, the "Table 1" column is equal to the "Table 5" column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion committed. I'm not sure whether we can link directly to a specific GitHub issue. @carlosapaduarte, do you know if that is possible? If not, perhaps we could add a code comment referencing the issue, at least for internal tracking.
Co-authored-by: Dan Tripp <[email protected]>
Closes #2233
Description:
Need for Call for Review:
This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve