Skip to content

Conversation

giacomo-petri
Copy link
Collaborator

Closes #2233

Description:

  • Added a note under "Accessibility Support" to clarify that headers and id are only partially supported, since certain AT/UA combinations do not work. See the test table for details
  • Clarified that Passed Example 3 works as intended but does not conform to the ARIA in HTML or HTML specs

Need for Call for Review:
This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

…ell refers to cells in the same table element [a25f45]

- Added accessibility supported note
- Added clarification that passed example 3 is not meeting ARIA in HTML and HTML specs
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 1c64229
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/68d0f3fb2271f6000844fe25
😎 Deploy Preview https://deploy-preview-2353--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

#### Passed Example 3

The `headers` attribute on the data cells in the second row refers to a `td` element with a role of `columnheader` within the same `table`.
Although this construct does not conform to the [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-td) or [HTML specifications](https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements), it behaves the same as using a `th` element instead of a `td` element with a role of `columnheader`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Although this construct does not conform to the [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-td) or [HTML specifications](https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements), it behaves the same as using a `th` element instead of a `td` element with a role of `columnheader`.
Although this construct does not conform to the [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-td) or [HTML specifications](https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements), it behaves the same as using a `th` element instead of a `td` element with a role of `columnheader`, on all popular browser / screen reader combinations, at the time of writing.

^^ because I think it would be valuable to note somehow that this is a snapshot in time, based on some (great!) testing that you did, and the behaviour could change. It's like an "Accessibility Support Note" for this example.

Also I wonder if it's worth linking to your test table. That would help future archeologists. And maybe even spell out the fact that your statement above ("it behaves the same...") was derived from the observation that in your test table, the "Table 1" column is equal to the "Table 5" column.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion committed. I'm not sure whether we can link directly to a specific GitHub issue. @carlosapaduarte, do you know if that is possible? If not, perhaps we could add a code comment referencing the issue, at least for internal tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passed Example 3 in Headers attribute specified on a cell refers to cells in the same table element [a25f45] should be edited/removed
3 participants