Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ruff #574

Merged
merged 22 commits into from
Dec 5, 2024
Merged

Introduce ruff #574

merged 22 commits into from
Dec 5, 2024

Conversation

mmacata
Copy link
Member

@mmacata mmacata commented Nov 19, 2024

See #539

This PR

  • adds fixes for simple ruff check . without further configuration.
  • adds all other errors to ignore list in new ruff.toml to be able to lint step by step in different commits.
  • adds post-pr-review workflow. As the on: workflow_run is only triggered when in main branch, let's see when merged if this is successful.

@mmacata mmacata marked this pull request as ready for review December 4, 2024 16:33
@mmacata mmacata requested a review from anikaweinmann December 4, 2024 16:33
Copy link
Member

@anikaweinmann anikaweinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the not running tests.

@mmacata mmacata merged commit 4dca658 into main Dec 5, 2024
20 checks passed
@anikaweinmann anikaweinmann added this to the 5.0.0 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants