Fix import-safe checks when scripts are run from a path with symlinks - #1265
Open
otaconix wants to merge 1 commit into
Open
Fix import-safe checks when scripts are run from a path with symlinks#1265otaconix wants to merge 1 commit into
otaconix wants to merge 1 commit into
Conversation
In v6, setup-java was made "import-safe" to facilitate testing. This prevents setup-java & cleanup-java from doing anything when their sources get imported. This works fine in the general case, but actually invoking the script (`node setup-java/index.js`) when the path to the script contains symlinks led to the script incorrectly believing it was imported, and refuse to actually run. To fix this, we pass `process.argv[1]` through `fs.realpathSync`, which resolves symlinks in the path. Fixes actions#1264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In v6, setup-java was made "import-safe" to facilitate testing. This prevents setup-java & cleanup-java from doing anything when their sources get imported.
This works fine in the general case, but actually invoking the script (
node setup-java/index.js) when the path to the script contains symlinks led to the script incorrectly believing it was imported, and refuse to actually run.To fix this, we pass
process.argv[1]throughfs.realpathSync, which resolves symlinks in the path.Fixes #1264
NB: I did run tests, and all but one succeeded, which I think is unrelated to my changes: the Jetbrains distributor test that checks
getAllAvailableVersionstimes out on my machine.Check list:
npm run checklocally (format, lint, build, test) and all checks pass.