Skip to content

Don't remove registry unless it is assigned #118

Description

@joebowbeer

Given that: If registry-url is specified then a @scope:registry= line will always be added to .npmrc if the registry is npm.pkg.github.com,

I think it's a bug for setup-node to remove the registry= line from .npmrc. In theory this line could be configuring a registry that is totally unrelated to GitHub packages.

In short, setup-node should only remove lines it is replacing.

In addition, I think better doc is needed regarding the use of the https://npm.pkg.github.com/owner proxy registry. Is setup-node compatible with the proxy registry? Or should an explicitly scoped registry always be used?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions