fix: panic when analysis insert into select stmt #2945

winfredLIN · 2025-03-04T07:43:09Z

关联的 issue

#2928

描述你的变更

修复在分析INSERT INTO ...... SELECT语句的时候，SELECT语句没有FROM导致的panic问题
修复在分析INSERT INTO ...... SELECT语句的时候，SELECT语句使用UNION导致的panic问题
增加了TODO项目，用于解决无法解析出SELECT子句中SELECT Field中的SUBQUERY refer的表

确认项（pr提交后操作）

Tip

请在指定复审人之前，确认并完成以下事项，完成后✅

我已完成自测
我已记录完整日志方便进行诊断
我已在关联的issue里补充了实现方案
我已在关联的issue里补充了测试影响面
我已确认了变更的兼容性，如果不兼容则在issue里标记 not_compatible
我已确认了是否要更新文档，如果要更新则在issue里标记 need_update_doc

sqle/driver/mysql/util/util.go

fix: panic if insert into select has no from in select stmt

3c24a5e

winfredLIN self-assigned this Mar 4, 2025

actiontech-bot requested a review from littleniannian March 4, 2025 07:43

fix: panic if INSERT INTO SELECT use UNION

57c70fe

winfredLIN changed the title ~~fix: panic if insert into select has no from in select stmt~~ fix: panic when analysis insert into select stmt Mar 4, 2025

littleniannian previously approved these changes Mar 4, 2025

View reviewed changes

littleniannian reviewed Mar 4, 2025

View reviewed changes

sqle/driver/mysql/util/util.go Show resolved Hide resolved

modify log

290ae86

winfredLIN dismissed littleniannian’s stale review via 290ae86 March 5, 2025 06:41

littleniannian approved these changes Mar 5, 2025

View reviewed changes

littleniannian merged commit c7edb9a into main Mar 5, 2025
3 checks passed

littleniannian deleted the 2928 branch March 5, 2025 06:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: panic when analysis insert into select stmt #2945

fix: panic when analysis insert into select stmt #2945

winfredLIN commented Mar 4, 2025 •

edited

Loading

fix: panic when analysis insert into select stmt #2945

fix: panic when analysis insert into select stmt #2945

Conversation

winfredLIN commented Mar 4, 2025 • edited Loading

关联的 issue

描述你的变更

确认项（pr提交后操作）

winfredLIN commented Mar 4, 2025 •

edited

Loading