Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scanner扫描带注释的xml文件报错 #2950

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

littleniannian
Copy link
Collaborator

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2229

描述你的变更

  • 使用regex去匹配替换行内注释

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

- 将 -- 注释替换为空格,而不是直接删除,以防止语句粘连
@winfredLIN winfredLIN merged commit f594360 into main Mar 7, 2025
3 checks passed
@littleniannian littleniannian deleted the fix_sql_line_comment branch March 7, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants