[WIP] export pydd waveforms to pycbc using the plugin protocol #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to adapt the https://github.com/adam-coogan/pydd/blob/main/scripts/load_strains_approx.py script in the repo so that one can generate the plus / cross polarizations of the dark dress waveform model easily.
This PR adds in a 'plugin' module which provides the common pycbc waveform generation interface (for td waveforms atm, we could add the interface for fourier domain later also here). This means that when pydd is installed, the waveform models automatically are found by pycbc and can be used within the common interfaces, routines, and programs. Once working, this will allow people to use the PyDD waveform within PE, searches, and create mock data using the model for further study.
Note, that at the moment, there appears to be some convention issue. As I am unable to reproduce the expected waveform behavior in the vacuum waveform limit. I've compared to the TaylorF2 approximant and the phasing / overlap is quite different. It's almost as if the mass scale were incorrect. It's possible that when adapting the script above, I have made a mistake, but if the pydd experts quickly spot the issue, please let me know.
The issue can be seen by running the following if both pydd and pycbc are installed.