Skip to content

fix negative rounding issue #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix negative rounding issue #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion numeral.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,20 @@
}

power = Math.pow(10, boundedPrecision);
isNegative = false;
if(parseFloat(value) < 0){
isNegative = true;
}

// Multiply up by precision, round accurately, then divide and use native toFixed():
output = (roundingFunction(value + 'e+' + boundedPrecision) / power).toFixed(boundedPrecision);
// we should use the rounding with the positive value! and if it is negative then make the output negative
if(isNegative){
output = (roundingFunction(-value + 'e+' + boundedPrecision) / power).toFixed(boundedPrecision);
output = '-'+output;
}
else{
output = (roundingFunction(value + 'e+' + boundedPrecision) / power).toFixed(boundedPrecision);
}

if (optionals > maxDecimals - boundedPrecision) {
optionalsRegExp = new RegExp('\\.?0{1,' + (optionals - (maxDecimals - boundedPrecision)) + '}$');
Expand Down