Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests Refactoring #740

Merged
merged 55 commits into from
Jan 27, 2025
Merged

Tests Refactoring #740

merged 55 commits into from
Jan 27, 2025

Conversation

TimoImhof
Copy link
Contributor

@TimoImhof TimoImhof commented Sep 16, 2024 •
edited
Loading

This PR aims to refactor the test suite into a more generic version.

The following points are to be covered (subject to change; will become more granular):

  • Add more granularity to test viewer for better test overview/readability and more convenient testing of subgroups of methods (e.g. only exectue LoRA tests for one model)
  • Add documentation about the structure of the test directory and entry points
  • Add pytest markers to allow for more granular testing of subgroups (e.g. exectue only LoRA tests for all models at once, useful when implementing a new adapter method)
  • Refactor test methods to extract similar/duplicate code into a set of utils methods
  • Relocate edgecases due to model peculiarities out of the tests and into the respective model test classes to keeps the tests generic
  • Fix config union tests, closes ConfigUnion test failures: Identical outputs with and without adapters when combining CompacterConfig and LoRAConfig #785

This should make it easier to add new models or methods to the existing test suite in the future and make the development/testing process more convenient in the future

TimoImhof and others added 10 commits September 16, 2024 10:10
@TimoImhof
Make generation tests generic
93bee1a
@TimoImhof
Merge remote-tracking branch 'origin/main' into dev/test-refactoring
f51cfdb
@TimoImhof
Draft Refactoring AdapterTestBase
7e65e82
@TimoImhof
Merge branch 'adapter-hub:main' into dev/test-refactoring
793cbe5
@TimoImhof
Replace import class names
65c3fb7
@TimoImhof
Merge branch 'dev/test-refactoring' of https://github.com/TimoImhof/a…
afdcfdd 
…dapters into dev/test-refactoring
@TimoImhof
Base refactoring:
ee6166c 
- reorder directory structure to separate testing models and adapter methods (needs further refactoring for separating tests that are extecuted for each model vs tests that are just run once)
- remove all model tests except albert for now (will be readded once final design is agreed on)
- refactor albert adapter test class to group test mixins in categories which are then displayed accordingly by test viewer
- adjust imports to reflect new directory structure
@TimoImhof
remove redundant imports
630b722
@TimoImhof
Add pytest markers and respective pytest commands
0d3577f
@TimoImhof
Add draft of README
1300856
@TimoImhof TimoImhof changed the title WIP: Generic Tests WIP: Tests Refactoring Nov 4, 2024
@TimoImhof
Refactoring:
78387db 
- refactor generate_test into base test class and adapt parallel generate test accordingly
- refactor lm head selection into own method
- create utils file for utility methods and adapt imports accordingly
- remove is_speech_model flags
- replace redundant attributes and methods
- enforce proper method naming conventions
@TimoImhof
Fix make quality
83d3b32
@TimoImhof
Add gpt2 tests
5e8e1b8
@TimoImhof
Fix config union and head tests
53eb0b9
@TimoImhof
Fix paths and imports
1dbd412
@TimoImhof
remove accidently added prompt tuning from gpt2 and make style
cf4f6a7
@TimoImhof
Revert PromptTuning changes
b390d61
@TimoImhof
Revert "Revert PromptTuning changes"
2193aee 
This reverts commit b390d61.
@TimoImhof
Re-add missing adapter model tests
f555484
@TimoImhof
Refactoring:
8dccda2 
- Re-add bart adapter method tests
- Remove duplicate added tests
- In conversion test refactor model specific if else statements into model test class
@TimoImhof
Introduce generic test creator function
c665948
@TimoImhof
Re-add beit adapter method tests
fb425b6
@TimoImhof
Refactor & Re-add bertgeneration and bert
225439c
@TimoImhof
Re-add clip tests
09f9cdc
@TimoImhof
Re-add:
7934350 
- deberta
- debertav2
- distilbert
- electra
- encoder-decoder
- llama
- mbart
- mistral
- mt5
- plbart
- roberta
@TimoImhof
Add more models
5f55935
@TimoImhof
Re-add whisper
147c8af
@TimoImhof
Changes:
b2979ce 
- introduce parameter to cut down on makefile commands
- draw out tests that are not executed on every model into a seperate directory
- move the adapter method test implemenations into the method tests directory
- rename files for more clarity
@TimoImhof
Add debug statements and only execute failing test
ffd21a9
@TimoImhof TimoImhof marked this pull request as ready for review December 26, 2024 10:29
@TimoImhof TimoImhof changed the title WIP: Tests Refactoring Tests Refactoring Dec 26, 2024
TimoImhof and others added 6 commits December 27, 2024 12:48
julian-fong added a commit to julian-fong/adapters that referenced this pull request Jan 11, 2025
@julian-fong
configure vera tests to adapter-hub#740
cd95c06
calpt
calpt reviewed Jan 18, 2025
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great overall! Also really appreciate the detailed readme!

Left a couple of comments mainly for clarification

tests/test_methods/method_test_impl/core/test_adapter_conversion.py Outdated Show resolved Hide resolved
tests/test_methods/method_test_impl/peft/test_config_union.py Outdated Show resolved Hide resolved
tests/test_methods/test_on_albert.py Show resolved Hide resolved
tests/test_methods/test_on_clip/test_model.py Show resolved Hide resolved
tests/test_methods/test_on_clip/test_model.py Outdated Show resolved Hide resolved
tests/test_methods/test_on_xlm_roberta.py Outdated Show resolved Hide resolved
tests/test_methods/method_test_impl/base.py Outdated Show resolved Hide resolved
tests/test_methods/method_test_impl/base.py Outdated Show resolved Hide resolved
tests/test_methods/generator.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@TimoImhof
Remove conversion method
4a0c2f7
@TimoImhof
Details:
91f9036 
- Merge branch 'main' into dev/test-refactoring
- Adress review comments
- make style, make quality
@TimoImhof
Transfer test class creation into if-statement
cdd81f9
@TimoImhof
Introduce new parameter to differentiate between redundant and not su…
3738ada 
…pported tests
@lenglaender lenglaender mentioned this pull request Jan 21, 2025
Merged
@TimoImhof TimoImhof requested a review from calpt January 27, 2025 17:00
calpt
calpt approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@calpt calpt merged commit 1dcac5c into adapter-hub:main Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calpt calpt calpt approved these changes

@lenglaender lenglaender Awaiting requested review from lenglaender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TimoImhof @calpt