docs(creative): clarify brand and catalog sourcing - #6443
Conversation
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated schema paths require human/CODEOWNERS approval.
This PR modifies static/schemas/source/core/brand-ref.json and static/schemas/source/core/creative-manifest.json, which fall under the deterministic hard approval gate (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so the gate is not satisfied and auto-approval is not permitted (decision rule row 2).
The change itself is a description-only clarification: a correct patch changeset plus expanded schema descriptions and a mirrored docs note in docs/creative/catalogs.mdx, establishing brand.json as the master brand-identity source. The reviewer found the schema descriptions, docs, and existing brand_kit_override merge semantics mutually coherent — no wire-shape change, no oneOf change, no dist edits, correct changeset type. No blocking findings were raised.
Escalation reasons:
- Touches gated path
static/schemas/source/core/brand-ref.json(modified) — human/CODEOWNERS review required;review_decisionisREVIEW_REQUIRED. - Touches gated path
static/schemas/source/core/creative-manifest.json(modified) — human/CODEOWNERS review required.
Once a real approval lands (review_decision: APPROVED), this clean diff can fall through to a normal approve.
Why human review
- Modifies gated path static/schemas/source/core/brand-ref.json; review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required.
- Modifies gated path static/schemas/source/core/creative-manifest.json; review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required.
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/core/brand-ref.json (modified) matches
static/schemas/source/**; static/schemas/source/core/creative-manifest.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
Summary
brand.jsonas the canonical source of master brand identity, with supportedbrand_kit_overridefields taking per-call precedenceCloses #5765.
Expert review
Validation
npm run test:schemas— 29 schema checks + 4 metadata checks passed across 693 schemasnpm run test:json-schema— 268 schema-backed documentation examples passednpm run lint:schema-linksnpm run test:docs-nav— 21/21 passed