Skip to content

test(compliance): verify deterministic read filters - #6572

Merged
bokelley merged 1 commit into
codex/dated-delivery-simulationsfrom
codex/filter-behavior-storyboards
Aug 15, 2026
Merged

test(compliance): verify deterministic read filters#6572
bokelley merged 1 commit into
codex/dated-delivery-simulationsfrom
codex/filter-behavior-storyboards

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

  • add required behavioral storyboards for get_media_buys ID/status membership, half-open dated delivery, and sales-agent list_creatives status/assignment filters
  • seed positive, independent negative, and boundary rows; assert membership and boundaries instead of response inequality
  • make public controller entity seeds visible in the task partition and make scoped delivery simulations authoritative
  • teach the training agent to honor list_creatives.media_buy_ids

Depends on #6567 (normative contract) and #6569 (dated delivery seeding). Refs #2902.

Validation

  • npm run typecheck
  • npm run build:compliance -- --check
  • compliance authoring lint suite
  • focused training-agent and controller unit tests (698 passed)
  • full server unit suite (6,132 passed; 30 skipped)
  • live focused sales storyboards for both new scenarios
  • current compliance storyboard matrix (all seven tenants)
  • frozen 3.0.22 compatibility storyboard matrix (all seven tenants)
  • docs navigation validation (21 passed)

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — behavioral conformance scenarios plus reference-implementation fixes for deterministic read filters.

No blocking findings. Reviewer verified: media_buy_ids is already present in creative-filters.json (L81), so honoring it in handleListCreatives is not schema drift; the half-open [start,end) range in read_filter_behavior.yaml (L646-668) matches getDeliverySimulationForPeriod's filter; the controller's sandbox:false task-partition projection lands seeds in the same open:<brand.domain> key ordinary reads derive after the SDK strips sandbox. Changeset present and protocol-scope-valid.

Only two low-severity notes, neither blocking:

  • read_filter_behavior.yaml:646 — half-open delivery boundaries verified correct
  • task-handlers.ts:8775 — scoped simulation reports whole-buy aggregate per package on multi-package buys

Gates checked: high_risk=false, gated_paths=false, no no-auto-approve team match, no prior decision. No critical/high/medium findings → falls through to row 9.

@bokelley
bokelley merged commit aa5b5dc into codex/dated-delivery-simulations Aug 15, 2026
5 checks passed
@bokelley
bokelley deleted the codex/filter-behavior-storyboards branch August 15, 2026 20:39
bokelley added a commit that referenced this pull request Aug 16, 2026
* feat(compliance): seed dated delivery simulations

* docs(media-buy): define half-open delivery ranges

* test(compliance): verify deterministic read filters (#6572)

* fix(compliance): align delivery range error code

* test(compliance): align empty range error code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant