test(compliance): verify deterministic read filters - #6572
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — behavioral conformance scenarios plus reference-implementation fixes for deterministic read filters.
No blocking findings. Reviewer verified: media_buy_ids is already present in creative-filters.json (L81), so honoring it in handleListCreatives is not schema drift; the half-open [start,end) range in read_filter_behavior.yaml (L646-668) matches getDeliverySimulationForPeriod's filter; the controller's sandbox:false task-partition projection lands seeds in the same open:<brand.domain> key ordinary reads derive after the SDK strips sandbox. Changeset present and protocol-scope-valid.
Only two low-severity notes, neither blocking:
- read_filter_behavior.yaml:646 — half-open delivery boundaries verified correct
- task-handlers.ts:8775 — scoped simulation reports whole-buy aggregate per package on multi-package buys
Gates checked: high_risk=false, gated_paths=false, no no-auto-approve team match, no prior decision. No critical/high/medium findings → falls through to row 9.
* feat(compliance): seed dated delivery simulations * docs(media-buy): define half-open delivery ranges * test(compliance): verify deterministic read filters (#6572) * fix(compliance): align delivery range error code * test(compliance): align empty range error code
Summary
get_media_buysID/status membership, half-open dated delivery, and sales-agentlist_creativesstatus/assignment filterslist_creatives.media_buy_idsDepends on #6567 (normative contract) and #6569 (dated delivery seeding). Refs #2902.
Validation
npm run typechecknpm run build:compliance -- --check