fix: reconcile stale billing state and correct PAIR mapping - #6698
Merged
Conversation
bokelley
marked this pull request as ready for review
August 19, 2026 22:13
Contributor
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated-paths approval gate not yet satisfied.
This PR modifies files under static/schemas/source/** (match-id-type.json, uid-type.json), which are declared under a hard, deterministic approval gate (gated_paths: true). The required review status is REVIEW_REQUIRED, not APPROVED, so the gate is not satisfied and the PR cannot be auto-approved (decision table row 2).
No blocking, High, or Medium findings were surfaced. The reviewer confirms:
- Billing self-heal rewrite in
lazy-reconcile.tsis well-tested (correct payload↔column mapping, optimisticupdated_atCAS guarding concurrent webhooks,customer_org_mismatchguard failing closed on cross-org entitlement transfer, 20s Stripe timeout, membership cache invalidation). - PAIR OpenRTB mapping correction (pair-protocol.com replacing iabtechlab.com/pair) is accurate and coherent across
match-id-type.json,uid-type.json,glossary.mdx, andmigration-from-axe.mdx, ships a correct patch changeset, and is patch-eligible as an erratum with legacy-alias handling. Schema↔docs coherence holds.
The diff is mechanically clean, but the schema-source gate requires a real human/CODEOWNERS approval before merge.
Escalation reasons
- Modifies gated schema-source files
static/schemas/source/enums/match-id-type.jsonandstatic/schemas/source/enums/uid-type.json;review_decisionisREVIEW_REQUIRED. Human/CODEOWNERS approval required to lift the gate.
Why human review
- Modifies gated schema-source files static/schemas/source/enums/match-id-type.json and static/schemas/source/enums/uid-type.json; review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required to satisfy the hard approval gate.
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/enums/match-id-type.json (modified) matches
static/schemas/source/**; static/schemas/source/enums/uid-type.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
bokelley
enabled auto-merge (squash)
August 19, 2026 22:21
bokelley
disabled auto-merge
August 20, 2026 04:55
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pair-protocol.com, preserve the publisher-ownerEID.matcherscope, and treat the older AdCP source only as a legacy input aliasIssue disposition
Resolves #6684.
This is a follow-up toward #6686, which must remain open until the named production accounts are synced and a production reconciliation run is observed.
#6687 is already covered by merged PR #6659; its same-day send behavior was revalidated here.
Validation