Skip to content
This repository was archived by the owner on Mar 15, 2026. It is now read-only.

Fix asset_type in creative manifest prompts - #25

Merged
bokelley merged 1 commit into
mainfrom
bokelley/preview-asset-type-fix
Oct 20, 2025
Merged

Fix asset_type in creative manifest prompts#25
bokelley merged 1 commit into
mainfrom
bokelley/preview-asset-type-fix

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Background

The ADCP spec no longer requires asset_type in creative manifest assets. This change corrects AI prompts that were incorrectly including it.

Changes

  • Modified AI prompts in src/creative_agent/server.py (lines 669-671 and 692-693) to remove the asset_type field from example asset structures.
    • Before: {"asset_type": "image", "url": "GENERATED_IMAGE_PLACEHOLDER", ...}
    • After: {"url": "GENERATED_IMAGE_PLACEHOLDER", ...}

Testing

  • Manually preview a creative that requires image, text, and URL assets.
  • Verify that no asset_type is present in the generated manifest.

@bokelley
bokelley merged commit 756ca70 into main Oct 20, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant