Skip to content
This repository was archived by the owner on Mar 15, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scripts/generate_schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,18 @@ def generate_schemas_from_json(schema_dir: Path, output_file: Path):
creative_asset_file.write_text(content)
print("✅ Fixed mypy issue in creative-asset schema")

# Fix mypy issue with webhook method default in build-creative-response
build_response_file = output_file / "_schemas_v1_media_buy_build_creative_response_json.py"
if build_response_file.exists():
content = build_response_file.read_text()
# Add type: ignore comment to the problematic line
content = content.replace(
'Field(description="HTTP method")] = "POST"',
'Field(description="HTTP method")] = "POST" # type: ignore[assignment]',
)
build_response_file.write_text(content)
print("✅ Fixed mypy issue in build-creative-response schema")

finally:
# Clean up temp directory
import shutil
Expand Down
5 changes: 1 addition & 4 deletions src/creative_agent/schemas/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,9 @@ class PreviewCreativeRequest(BaseModel):
"""Request for preview_creative task."""

format_id: FormatId
creative_manifest: dict[str, Any] # AdCP CreativeAsset structure
creative_manifest: dict[str, Any] # AdCP CreativeAsset structure (including promoted_offerings if required)
inputs: list[PreviewInput] | None = None
template_id: str | None = None
brand_card: dict[str, Any] | None = None
promoted_products: dict[str, Any] | None = None
asset_filters: dict[str, Any] | None = None


class PreviewHints(BaseModel):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class Assets(BaseModel):
] = None


class Assets16(BaseModel):
class Assets14(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -70,7 +70,7 @@ class Assets16(BaseModel):
] = None


class Assets17(BaseModel):
class Assets15(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -113,7 +113,7 @@ class TrackingEvent(Enum):
player_collapse = "playerCollapse"


class Assets18(BaseModel):
class Assets16(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -140,7 +140,7 @@ class Assets18(BaseModel):
] = None


class Assets19(BaseModel):
class Assets17(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -167,7 +167,7 @@ class Assets19(BaseModel):
] = None


class Assets20(BaseModel):
class Assets18(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -177,7 +177,7 @@ class Assets20(BaseModel):
] = None


class Assets21(BaseModel):
class Assets19(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -187,7 +187,7 @@ class Assets21(BaseModel):
] = None


class Assets22(BaseModel):
class Assets20(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -203,7 +203,7 @@ class ModuleType(Enum):
script = "script"


class Assets23(BaseModel):
class Assets21(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -242,7 +242,7 @@ class Security(BaseModel):
] = None


class Assets24(BaseModel):
class Assets22(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -276,7 +276,7 @@ class Assets24(BaseModel):
]


class Assets25(BaseModel):
class Assets23(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -306,7 +306,7 @@ class TrackingEvent10(Enum):
unmute = "unmute"


class Assets26(BaseModel):
class Assets24(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -330,7 +330,7 @@ class Assets26(BaseModel):
] = None


class Assets27(BaseModel):
class Assets25(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -735,7 +735,7 @@ class AssetSelectors(BaseModel):
] = None


class Assets28(BaseModel):
class Assets26(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -824,17 +824,17 @@ class CreativeManifest(BaseModel):
str,
Union[
Assets,
Assets16,
Assets17,
Union[Assets18, Assets19],
Assets14,
Assets15,
Union[Assets16, Assets17],
Assets18,
Assets19,
Assets20,
Assets21,
Assets22,
Assets23,
Assets24,
Assets25,
Union[Assets26, Assets27],
Assets28,
Union[Assets24, Assets25],
Assets26,
],
],
Field(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class Assets(BaseModel):
] = None


class Assets30(BaseModel):
class Assets28(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -70,7 +70,7 @@ class Assets30(BaseModel):
] = None


class Assets31(BaseModel):
class Assets29(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -113,7 +113,7 @@ class TrackingEvent(Enum):
player_collapse = "playerCollapse"


class Assets32(BaseModel):
class Assets30(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -140,7 +140,7 @@ class Assets32(BaseModel):
] = None


class Assets33(BaseModel):
class Assets31(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -167,7 +167,7 @@ class Assets33(BaseModel):
] = None


class Assets34(BaseModel):
class Assets32(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -177,7 +177,7 @@ class Assets34(BaseModel):
] = None


class Assets35(BaseModel):
class Assets33(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -187,7 +187,7 @@ class Assets35(BaseModel):
] = None


class Assets36(BaseModel):
class Assets34(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -203,7 +203,7 @@ class ModuleType(Enum):
script = "script"


class Assets37(BaseModel):
class Assets35(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -242,7 +242,7 @@ class Security(BaseModel):
] = None


class Assets38(BaseModel):
class Assets36(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -276,7 +276,7 @@ class Assets38(BaseModel):
]


class Assets39(BaseModel):
class Assets37(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -306,7 +306,7 @@ class TrackingEvent14(Enum):
unmute = "unmute"


class Assets40(BaseModel):
class Assets38(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand All @@ -330,7 +330,7 @@ class Assets40(BaseModel):
] = None


class Assets41(BaseModel):
class Assets39(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -735,7 +735,7 @@ class AssetSelectors(BaseModel):
] = None


class Assets42(BaseModel):
class Assets40(BaseModel):
model_config = ConfigDict(
extra="forbid",
)
Expand Down Expand Up @@ -820,17 +820,17 @@ class CreativeManifest(BaseModel):
str,
Union[
Assets,
Assets30,
Assets31,
Union[Assets32, Assets33],
Assets28,
Assets29,
Union[Assets30, Assets31],
Assets32,
Assets33,
Assets34,
Assets35,
Assets36,
Assets37,
Assets38,
Assets39,
Union[Assets40, Assets41],
Assets42,
Union[Assets38, Assets39],
Assets40,
],
],
Field(
Expand Down Expand Up @@ -891,9 +891,3 @@ class PreviewCreativeRequest(BaseModel):
Optional[str],
Field(description="Specific template ID for custom format rendering"),
] = None
promoted_offerings: Annotated[
Optional[Any],
Field(
description="Circular reference to /schemas/v1/core/promoted-offerings.json"
),
] = None
Loading