Adds optional $config parameter to API instance constructor

[vedmaka]

The change adds optional $config parameter to MediaWiki instance constructor. With the optional $config param it's not possible to supply internal Guzzle client with extra parameters [1] like timeout and connect_timeout.

Additionally there is a special noretry flag added to be processed by MiddlewareFactory to allow to disable 5x retries which are enabled by default.

For example:

$api = MediaWiki::newFromEndpoint( 'https://mywiki.com', null, [
    'timeout' => 60,
    'connect_timeout' => 30,
    'noretry' => true
] );

[DanielWTQ]

@addshore @JeroenDeDauw would you mind taking a look at this?

[samwilson]

It seems like it might be better to inject a whole $client object, rather than just the config. e.g.:

$clientFactory = new ClientFactory( [
	'timeout' => 60,
	'connect_timeout' => 30,
	'noretry' => true
] );
$api = MediaWiki::newFromPage( 'http://example.org', null, $clientFactory->getClient() );

Or, what if instead the client in an ActionApi object could be changed after instantiation? e.g.:

$api = MediaWiki::newFromPage( 'http://example.org' );
$clientFactory = new ClientFactory( [
	'timeout' => 60,
	'connect_timeout' => 30,
	'noretry' => true
] );
$api->setClient( $clientFactory->getClient() );

[DanielWTQ]

It seems like it might be better to inject a whole $client object, rather than just the config

Given how long this patch has been sitting without review, would it be possible to merge the current feature, and then do further improvements from there?

[samwilson]

If this was merged there wouldn't be any point in adding a different way, I think (because we'd still want to keep it backwards compatible and so would just end up with two ways to pass in the Guzzle config). @addshore is the main maintainer here, it's up to him.

I think being able to inject a different client would be more flexible, e.g. when integrating this package into an existing application.