Skip to content

feat: add new skills, agent personas, and LLM integration checklist#254

Open
rickrapozo wants to merge 3 commits into
addyosmani:mainfrom
rickrapozo:feat/new-skills-personas-references
Open

feat: add new skills, agent personas, and LLM integration checklist#254
rickrapozo wants to merge 3 commits into
addyosmani:mainfrom
rickrapozo:feat/new-skills-personas-references

Conversation

@rickrapozo

Copy link
Copy Markdown

Summary

Adds three new skills, two agent personas, and one reference checklist to expand the project's coverage of common engineering workflows.

New Skills

  • llm-api-integration -- Structured process for integrating LLM APIs (prompt safety, JSON schema output, exponential backoff, mock-based testing)
    • accessibility-testing-and-remediation -- End-to-end a11y audit workflow (automated checks, keyboard audit, screen reader validation, regression testing)
    • database-migrations-and-schema-design -- Schema design with constraints, strategic indexing, zero-downtime migrations (Expand-Contract pattern), and rollback scripts

New Personas

  • a11y-auditor -- Accessibility Engineer persona for WCAG 2.1 AA audits
    • db-architect -- Database Architect persona for schema review, migration safety, and query optimization

New Reference

  • references/llm-integration-checklist.md -- Quick-reference checklist for safe, resilient LLM integrations

Validation

  • node scripts/validate-skills.js -> 27 skills, 0 errors, 0 warnings - PASSED
    • bash hooks/session-start-test.sh -> session-start JSON payload OK
      All new content follows the skill-anatomy.md format and agents/README.md guidelines.

…g-and-remediation, database-migrations-and-schema-design)

Adds production-grade workflows for:

- Integrating LLM APIs with prompt safety, structured output, and retry logic

- Systematic accessibility testing and WCAG 2.1 AA remediation

- Database schema design with zero-downtime migrations
Adds two new specialist personas:

- a11y-auditor: WCAG 2.1 AA compliance auditor with keyboard and screen reader focus

- db-architect: Schema review, migration safety, and query optimization specialist

Updates agents/README.md table to include both new personas.
Covers prompt safety, structured output, resilience, token management,

and testing anti-patterns. Referenced by the llm-api-integration skill.
@nucliweb

Copy link
Copy Markdown
Contributor

Thanks for this, there's genuinely useful content here. One piece of feedback on packaging that I think would help it land.

Right now the PR bundles a lot into one changeset: 3 skills (llm-api-integration, accessibility-testing-and-remediation, database-migrations-and-schema-design), 2 personas (a11y-auditor, db-architect), and 1 reference checklist, across 762 lines and 7 files. That breadth makes it hard to review as a unit, and it overlaps with other open PRs that target the same areas independently:

Would you be open to splitting this into atomic PRs, one skill per PR? That lets each piece be reviewed and merged on its own merits, and lets the maintainer coordinate the overlapping ones without blocking the rest.

In particular, database-migrations-and-schema-design looks like the strongest candidate to land standalone: it fills a real gap (no current skill covers schema design or migrations), it doesn't overlap with any other open PR, and the content is solid as-is, Expand-Contract for zero-downtime, strategic indexing, rollback scripts, and EXPLAIN ANALYZE profiling. Pulling just that one into its own PR would likely move fast.

Happy to help review the split PRs if useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants