Feature/306/feature to add custom package #340

spuday90 · 2021-07-09T03:35:04Z

CLoses #306

hegocre · 2021-07-11T14:37:38Z

Tried this branch. Here are some problems that I found:

Watomatic not detecting the app is installed, although it is (I suppose this is also the reason why the app icon is not shown).
Adding the same package name two times results in the app crashing.
Changing enabled apps to a custom one does not update the main screen until a restart.

Also some suggestions:

Move the option to add packages to the enabled apps screen
Add the option to remove a custom package

I can give more info or explain better if something is unclear, let me know!

spuday90 · 2021-07-12T02:19:23Z

Hi @hegocre ,
Thanks for your feedback, ill look into them.

…lected item checkbox

spuday90 · 2021-07-23T03:41:42Z

~~Known issue : Select/Deselect any item and scroll up/down then the state is missing first time - Working on it -- Resolved~~

List segregation/sorting - b8d314b
~~- [ ] Show alert dialog when pressed back without saving~~ this is not needed as we are saving on each click

spuday90 · 2021-07-23T03:45:29Z

Screenrecorder-2021-07-23-09-10-31-36.mp4

adeekshith · 2021-07-23T03:50:34Z

@spuday90 Can you also add a warning dialog when floating "+" button is clicked. Something like "Not tested to work with apps in the list and can cause unintended issues. Use at your own risk." With cancel and accept buttons.

spuday90 · 2021-07-23T03:54:20Z

@spuday90 Can you also add a warning dialog when floating "+" button is clicked. Something like "Not tested to work with apps in the list and can cause unintended issues. Use at your own risk." With cancel and accept buttons.

Added in abb51ae
Removed "Use at your own risk" its looking as if device can be damaged or so. Feel free to add it if u think is needed

… triggered even when we manually change the state, so it was adding or removing the items even when we scroll

spuday90 · 2021-07-24T06:32:32Z

Changed the UI to be in sync with contact selector

hegocre · 2021-07-25T10:33:18Z

Tested this branch again, everything works right except for the installed apps list, which is weird (see screenshot). I imagine it is because of the rtl approach, so I would suggest using the method shown here, or just using a TextView + Checkbox instead, which I can implement if you are busy.

spuday90 · 2021-07-26T03:41:19Z

Tested this branch again, everything works right except for the installed apps list, which is weird (see screenshot). I imagine it is because of the rtl approach, so I would suggest using the method shown here, or just using a TextView + Checkbox instead, which I can implement if you are busy.

Hi @hegocre ,
Thanks for reporting the issue. Its behaving differently on different devices.
I'm just checking for any better solution, if couldn't find any will implement what you have suggested i.e using separate textview+checkbox.

Fixed in 6e19f99
@hegocre Please test now

hegocre · 2021-07-27T13:30:07Z

It is fixed indeed. Now I'm facing a couple of issues

App names are not visible on dark theme, can be fixed by changing

watomatic/app/src/main/res/layout/installed_apps_list.xml

Line 28 in 6e19f99

android:textColor="@color/black"

with android:textColor="?colorOnSurface"

Apps are still not detected as installed on the enabled apps selector, as shown on the media below:

Looks like it's checking the app against the SUPPORTED_APPS constant here

watomatic/app/src/main/java/com/parishod/watomatic/model/utils/Constants.kt

Lines 29 to 33 in 6e19f99

    
           val SUPPORTED_APPS: Set<App> = setOf( 
        
                   App("WhatsApp", "com.whatsapp"), 
        
                   App("Facebook Messenger", "com.facebook.orca"), 
        
                   // App("Facebook Messenger Lite", "com.facebook.mlite"), 
        
           )

instead of checking against installed apps.

Other than that, great work, I think it's nearly working perfectly, and it will be a great addition to Watomatic.

spuday90 · 2021-07-28T02:28:10Z

Hi @hegocre,
Yes app not installed is a known issue, Earlier we didn't had the query_all package permission so was not able to detect app. I will fix that.

hegocre · 2021-07-28T11:40:15Z

Nice, tried it with telegram, it works great!

Goldmaster · 2021-11-21T09:07:05Z

Is there an eta, of when this will be added? This would also solve quite a few other requests such as support for messenger lite, discord and telegram.

Signed-off-by: hegocre <[email protected]> # Conflicts: # app/src/main/java/com/parishod/watomatic/adapter/SupportedAppsAdapter.kt # app/src/main/java/com/parishod/watomatic/fragment/EnabledAppsFragment.kt # app/src/main/java/com/parishod/watomatic/fragment/MainFragment.java # app/src/main/java/com/parishod/watomatic/model/App.kt # app/src/main/java/com/parishod/watomatic/model/utils/CustomDialog.java # app/src/main/java/com/parishod/watomatic/model/utils/NotificationHelper.java # app/src/main/res/values/strings.xml

hegocre · 2021-11-23T17:07:37Z

Merged main into this to solve merge conflicts, this should be tested. And maybe release a new version? There are some nice changes since the last one.

adeekshith · 2021-11-24T15:29:26Z

Is there an eta, of when this will be added? This would also solve quite a few other requests such as support for messenger lite, discord and telegram.

Main reason for not merging this is Google Play has new policies regarding apps having permission to access entire apps list. We are now required to apply to them separately with justification, etc for this. And then they would scrutinize the app and websites before giving permissions. Some of the apps recently got removed from Play store for having a donation button on the website. Watomatic has that too so need to figure out having an alternative URL for Play Store users which does not show Donation button. It is not clear we are violating Play Store policies but there is a gray area there. Need to clear those bureaucratic hurdles before this can merged

adeekshith · 2021-11-24T15:31:21Z

Merged main into this to solve merge conflicts, this should be tested. And maybe release a new version? There are some nice changes since the last one.

Thank you @hegocre 🙌

Will make a release next week. Thats true, its long overdue 😊
Will merge this PR after the release though because of this:
#340 (comment)

spuday90 added 6 commits July 9, 2021 08:21

refactor move App class to logs package

ae0dbd2

convert App class to Room Entity

341af96

create interface to read and write supported app data to db

2414229

read/write supported app data from db

42562ee

bugfix use packagename itself as primary key

01fa773

implement feature to add custom app

7ce7765

spuday90 requested a review from adeekshith July 9, 2021 03:35

allow enabling the custom package with option to install the app

f935927

no need to check app install from google play

398f0c3

spuday90 added 9 commits July 12, 2021 08:23

show install option for all the apps

128c9e5

check if the entered package already exists

615becb

move add custom apps to EnabledAppsFragment

be3e78c

on saving finish the activity to will show the updated list immediately

877b838

replace custom apps editbox with recyclerview

420449d

fetch installed apps list and display in recyclerview, also handle se…

01d7a18

…lected item checkbox

add shimmer effect for apps loading

b5fef14

add support to remove app from db

315e29c

add fab to save the selection changes

43eab31

spuday90 added 3 commits July 24, 2021 11:47

change design to checkboxes, also add/remove app to db immediately

07b5870

remove unnecessary interface and methods

ce66641

bugfix use onclicklistener instead of checkchange listener as it gets…

1edfb9d

… triggered even when we manually change the state, so it was adding or removing the items even when we scroll

spuday90 added 2 commits July 24, 2021 12:04

Merge branch 'main' into feature/306/feature_to_add_custom_package

07598f0

refactor remove unused strings

51dde6e

spuday90 added 2 commits July 26, 2021 07:58

show beta feature warning

abb51ae

filter out officially supported apps from list

f781d2f

spuday90 added 2 commits July 26, 2021 09:38

sort the list selected apps first

b8d314b

use separate textview and checkbox to avoid rtl issue

6e19f99

spuday90 added 3 commits July 28, 2021 08:02

bugfix change title color to support dark theme

2e6356c

bugfix handle couldn't detect app

124894a

refactor remove unused value

52e9cd0

This was referenced Apr 6, 2022

Can't use with Messenger Lite #367

Open

Auto reply SMS #248

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/306/feature to add custom package #340

Feature/306/feature to add custom package #340

spuday90 commented Jul 9, 2021 •

edited

Loading

hegocre commented Jul 11, 2021

spuday90 commented Jul 12, 2021

spuday90 commented Jul 23, 2021 •

edited

Loading

spuday90 commented Jul 23, 2021

adeekshith commented Jul 23, 2021

spuday90 commented Jul 23, 2021 •

edited

Loading

spuday90 commented Jul 24, 2021

hegocre commented Jul 25, 2021 •

edited

Loading

spuday90 commented Jul 26, 2021 •

edited

Loading

hegocre commented Jul 27, 2021 •

edited

Loading

spuday90 commented Jul 28, 2021 •

edited

Loading

hegocre commented Jul 28, 2021

Goldmaster commented Nov 21, 2021

hegocre commented Nov 23, 2021

adeekshith commented Nov 24, 2021

adeekshith commented Nov 24, 2021

Feature/306/feature to add custom package #340

Are you sure you want to change the base?

Feature/306/feature to add custom package #340

Conversation

spuday90 commented Jul 9, 2021 • edited Loading

hegocre commented Jul 11, 2021

spuday90 commented Jul 12, 2021

spuday90 commented Jul 23, 2021 • edited Loading

spuday90 commented Jul 23, 2021

adeekshith commented Jul 23, 2021

spuday90 commented Jul 23, 2021 • edited Loading

spuday90 commented Jul 24, 2021

hegocre commented Jul 25, 2021 • edited Loading

spuday90 commented Jul 26, 2021 • edited Loading

hegocre commented Jul 27, 2021 • edited Loading

spuday90 commented Jul 28, 2021 • edited Loading

hegocre commented Jul 28, 2021

Goldmaster commented Nov 21, 2021

hegocre commented Nov 23, 2021

adeekshith commented Nov 24, 2021

adeekshith commented Nov 24, 2021

spuday90 commented Jul 9, 2021 •

edited

Loading

spuday90 commented Jul 23, 2021 •

edited

Loading

spuday90 commented Jul 23, 2021 •

edited

Loading

hegocre commented Jul 25, 2021 •

edited

Loading

spuday90 commented Jul 26, 2021 •

edited

Loading

hegocre commented Jul 27, 2021 •

edited

Loading

spuday90 commented Jul 28, 2021 •

edited

Loading