fix make test compatibility on windows#6540
Merged
TimothyZhang7 merged 1 commit intoaden-hive:mainfrom Mar 17, 2026
Merged
Conversation
Contributor
Author
|
please look into this PR and let me know if there any changes needed |
Contributor
Author
|
hey @Hundao ...can you please look into it ...really a small pr but really important one . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
make test(and all othermaketargets) failing on Windows when using Git Bash.uvinstalls itself to~/.local/bin, which Git Bash does not include inPATHby default, causing everyuv runcommand to fail with'uv' is not recognized.Type of Change
Related Issues
Fixes #6270
Changes Made
~/.local/bintoPATHin the Makefile souvis discoverable by Git Bash on Windowsifeq ($(OS),Windows_NT)) that introducedcd /d— a cmd.exe-only flag that broke Git Bashcdfor all targets, which works correctly across Git Bash, macOS, and LinuxTesting
Describe the tests you ran to verify your changes:
cd core && pytest tests/)cd core && ruff check .)make testsuccessfully in Git Bash on Windows after the fix; confirmed the previous'uv' is not recognizederror is goneChecklist
Screenshots (if applicable)
Before:

make testfails with'uv' is not recognized as an internal or external commandAfter:

make testruns all pytest suites successfully in powershell on Windows.