Don't wrap struct padding in __bindgen_marker_Opaque
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as with zero-sized structs, this usage of blob() doesn't mean the type is opaque: padding is perfectly safe to allocate, modify, and pass around. By marking it with __bindgen_marker_Opaque, we prevent autocxx from making padded structs POD. This hasn't cropped up so far because explicit padding fields are quite rare in bindgen, but they do show up when a struct ends with a bitfield. I'm about to contribute POD bitfield support to autocxx, which this fix helps enable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as with zero-sized structs, this usage of
blob()doesn't mean the type is opaque: padding is perfectly safe to allocate, modify, and pass around. By marking it with__bindgen_marker_Opaque, we prevent autocxx from making padded structs POD.This hasn't cropped up so far because explicit padding fields are quite rare in bindgen, but they do show up when a struct ends with a bitfield. I'm about to contribute POD bitfield support to autocxx (edit: now submitted as google/autocxx#1478), which this fix helps enable.