Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in the headers and one incorrect function signature #78

Closed
wants to merge 4 commits into from
Closed

Fixed typos in the headers and one incorrect function signature #78

wants to merge 4 commits into from

Conversation

DidierMalenfant
Copy link
Contributor

No description provided.

@DidierMalenfant
Copy link
Contributor Author

I also just added a fix for a warning in Release builds

@t-w
Copy link
Collaborator

t-w commented Feb 22, 2024

Hi.
Thanks for correcting these.

However, I would like to ask you that we close this PR. I have a lot of new/changed stuff in my fork (t-w/ADFlib) where further development is and probably will be done so that Laurent (@lclevy) is not bothered that much with PRs and stuff.

(I know there is no info about it yet... I will ask him to put info about it in the project description).

The latest (working) code should be, like here, in the devel branch. So if you open a PR to that one, I can merge it (I have just merge the latest stuff there).

(Merging this here would require a lot work with resolving conflicts, some modified files may have been renamed etc. so, it will be easier to update it on your side than mine...).

@DidierMalenfant
Copy link
Contributor Author

So is your fork the main repo for the project now?

@t-w
Copy link
Collaborator

t-w commented Feb 22, 2024

At the moment, in practice, that is the main development repo, while here goes things for release. We will see if we move everything (releases) there or keep them here.

Anyway, to go on with this one - I pushed the current stuff to the refactor branch in this repo. You can pull it, make your changes and update your devel so that the changes appear here.

@DidierMalenfant
Copy link
Contributor Author

You let me know what you prefer, I don't want it to get too confusing...

I've started making these changes for your other repo as requested, I'll close this one and submit another one there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants