0.9.0 #81
Merged
0.9.0 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better type safety. Also, renamed to separate the namespace.
…ties. This is done to distinguish the functions for checking the type of the filesystem from the functions for checking its properties. (Both regarding the original A. DOS filesystems.)
…unctions. Separating ADFlib's namespace, better type safety.
With static locals, the results of concurrent calls are unpredictible.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
These arrays are in file header blocks and file ext. blocks. (Separating ADFlib's namespace).
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Separating ADFlib's namespace.
Also, correct sources that were relying on that.
Remove unneeded include (not even exising anymore...).
2 unit test were using the same adf filenames as test devices, so the tests, when executed in parallel (building debs) were failing. Fixed making unique filenames.
Library headers listed as _HEADERS are being installed along with the library, while the private sources should not (they are needed only for building the library itself). Such private headers can be specified as noist_HEADERS, or, what is recommender by Automake manual, just as _SOURCES. Note, that if the private headers are completely omitted, make distcheck fails.
The DLL export prefix is required only in headers (in declarations).
Separating ADFlib's namespace.
The tested function is from a private library module, it is not exported by the library, so the module must be linked directly.
Lintian complained about privacy breach.
When appending data to an existing OFS block, the dataSize field in the block header wasn't being extended. So if you wrote a file via fuseadf, 4Kb at a time, then the first 4Kb write would terminate in mid-block leaving that block's dataSize indicating that it was half full; then the second 4Kb write would write the first part of its data into the partial block but leave that block's dataSize field unchanged. An emulated Workbench 1.3 era Amiga would honour the dataSize field and treat the partial block as short, losing the initial segment of the second 4Kb of the source file.
adfFileWrite: update dataSize when extending an OFS block.
lclevy
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.