Skip to content

added offset checks for the ISO 8601 issue #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2018
Merged

added offset checks for the ISO 8601 issue #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lrs/utils/StatementValidator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,12 @@ def validate_statement(self, stmt):
timestamp = stmt['timestamp']
try:
parse_datetime(timestamp)

# Reject statements that don't comply with ISO 8601 offsets
if timestamp.endswith("-00") or timestamp.endswith("-0000") or timestamp.endswith("-00:00"):
self.return_error(
"Timestamp error - Statement Timestamp Illegal offset (-00, -0000, or -00:00) %s" % timestamp)

except Exception as e:
self.return_error(
"Timestamp error - There was an error while parsing the date from %s -- Error: %s" % (timestamp, e.message))
Expand Down Expand Up @@ -640,6 +646,12 @@ def validate_substatement(self, substmt):
timestamp = substmt['timestamp']
try:
parse_datetime(timestamp)

# Reject statements that don't comply with ISO 8601 offsets
if timestamp.endswith("-00") or timestamp.endswith("-0000") or timestamp.endswith("-00:00"):
self.return_error(
"Timestamp error - Substatement Timestamp Illegal offset (-00, -0000, or -00:00) %s" % timestamp)

except Exception as e:
self.return_error(
"Timestamp error - There was an error while parsing the date from %s -- Error: %s" % (timestamp, e.message))
Expand Down