Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four issues in section 7 #691

Merged
merged 5 commits into from
May 27, 2015
Merged

Conversation

garemoko
Copy link
Contributor

Fixes #601 #671 #674 #656

@andyjohnson
Copy link
Contributor

I wonder about the SHOULD* aspect of some of these. The Last-Modified requirement seems like it would be the only acceptable behavior for an LRS, but I haven't implemented one - is this the case?

I have more of an issue with the defined additional endpoints all going under /extensions. I agree it is at least a SHOULD and I agree that in 2.0, we could move all non-xAPI endpoints there (with a MUST), but where this breaks down, in my opinion, is in the intent of the SHOULD_. SHOULD_s have been essentially restricted to the only possible or only reasonable practice, but without supporting spec language to justify a MUST. I feel this is a bit different. It is perfectly reasonable that other endpoints were defined for an LRS and not mapped to /extensions in 1.0.2. If implementors were thinking of future interoperability, they may have decided placement in extensions is appropriate, but that may be applying our goals to someone just building a product.

@garemoko
Copy link
Contributor Author

garemoko commented May 5, 2015

I agree that we do seem to have a disconnect in our understanding of 'SHOULD'. My understanding was that SHOULD is simply a recommendation of best practice and that we were ok with adding additional best practices in 1.0.3 that were not in 1.0.2.

@brianjmiller
Copy link
Contributor

I'm not sure which direction your "Last-Modified" question was going, IOW on the behavior of it as a SHOULD* or on it being a SHOULD* at all. I would think this is the only sensible behavior given you will (or eventually must) include a "Last-Modified" header. With the other possible behavior to just not include one which is what this is trying to prevent.

@andyjohnson
Copy link
Contributor

I shouldn't beat around the bush so much, or if I do, at least say what I think at the end:

SHOULD* for "Last-Modified" 👍 SHOULD (regular) for the endpoint 👍

I have no doubt we would, in a 2.0 version, force additional endpoints into this bucket, but don't feel it should have the weight in 1.0.3 of a SHOULD*.

@garemoko
Copy link
Contributor Author

garemoko commented May 7, 2015

That first star is now removed.

@andyjohnson
Copy link
Contributor

+1 for you @garemoko ! And a free 🍔

andyjohnson added a commit that referenced this pull request May 27, 2015
@andyjohnson andyjohnson merged commit 229ac43 into adlnet:1.0.3 May 27, 2015
@garemoko garemoko deleted the issues-601-671-674-656 branch May 27, 2015 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants