Fix DeleteThumbnail Status Codes #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbader-sap
requested review from
BirgitBoss,
alexgordtop,
aorzelskiGH,
danielporta,
g1zzm0,
getag,
mjacoby,
waltersve and
zrgt
as code owners
BirgitBoss
reviewed
Jul 14, 2025
| - Asset Administration Shell Repository API | ||
| operationId: DeleteThumbnail_AasRepository | ||
| x-semanticIds: | ||
| - https://admin-shell.io/aas/API/DeleteThumbnail/3/0 |
BirgitBoss
reviewed
Jul 14, 2025
| - Asset Administration Shell API | ||
| operationId: DeleteThumbnail | ||
| x-semanticIds: | ||
| - https://admin-shell.io/aas/API/DeleteThumbnail/3/0 |
BirgitBoss
reviewed
Jul 14, 2025
| - Asset Administration Shell Repository API | ||
| operationId: DeleteThumbnail_AasRepository | ||
| x-semanticIds: | ||
| - https://admin-shell.io/aas/API/DeleteThumbnail/3/0 |
BirgitBoss
reviewed
Jul 14, 2025
| - Asset Administration Shell API | ||
| operationId: DeleteThumbnail | ||
| x-semanticIds: | ||
| - https://admin-shell.io/aas/API/DeleteThumbnail/3/0 |
BirgitBoss
requested changes
Jul 14, 2025
Collaborator
BirgitBoss
left a comment
BirgitBoss
left a comment
There was a problem hiding this comment.
should be DeleteThumbnail/3/1, no?
Contributor
Author
|
I don't remember anymore whether we wanted to increase all semantiId URIs... This is a problem not dependent to the DeleteThumbnail Status Codes issue but a more generic one. I will create a separate PR with all semanticIds including |
Contributor
Author
|
See #491 |
BirgitBoss
approved these changes
Jul 15, 2025
Collaborator
BirgitBoss
left a comment
BirgitBoss
left a comment
There was a problem hiding this comment.
the versioning /3/1 was solved in #491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #469