Skip to content

glTF import plugin preserves joint names #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

glTF import plugin preserves joint names #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gltf/src/gltfImport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,7 +1579,7 @@ importMeshes(ImportGltfContext& ctx)
// Import skeletons from gltf.
// First traverses all glTF nodes in the scene, to construct names appropriate for UsdSkel API
// consumption (for the Skeleton::joints attribute), of the form:
// n0/n1/n2...
// rootJoint/childJoint1/childJoint2...
// Then traverses all glTF skins and assembles skeleton data in the Usdata cache.
// This doesn't specify instantiation of any skeletons, which is done by importNodes.
// It's ok that importNodes runs before this one, because the skins and skeletons counts are
Expand All @@ -1591,7 +1591,7 @@ importSkeletons(ImportGltfContext& ctx)
std::function<void(int parentIndex, int nodeIndex)> buildSkeletonNodeNames;
buildSkeletonNodeNames = [&](int parentIndex, int nodeIndex) {
const tinygltf::Node& node = ctx.gltf->nodes[nodeIndex];
std::string name = "n" + std::to_string(nodeIndex);
std::string name = node.name;
ctx.skeletonNodeNames[nodeIndex] =
parentIndex >= 0 ? ctx.skeletonNodeNames[parentIndex] + "/" + name : name;
for (size_t i = 0; i < node.children.size(); i++) {
Expand Down