Content card containers #540
Draft
+33,020
−11,247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Image only template
remove changes in Contentview, will make the changes in the other PR.
remove extra line
Update Image only template and bug fixes
Update image only test
Fix Content Card View outdated ContentTemplates
…sForSurfaces([surface]) initialize page Update the failing unit test and updated sample app
Fix Content Card View outdated ContentTemplates
update integration with track PR
…e into content-card1
Upate RCTAEPMessaging
fix unit test
merge update
Synced with Staging branch and integrate with new Track API
Update tutorial doc for content card
update Content card customization guide
update sample package dependency
update yarn.lock file
fix CI test
add timeout for ci steps
fix ci tests
remove -network-concurrency
fix config indentation
Increasing the memory limit from 4GB,
…smiss update for Rendered fewer hooks than expected error" when clicking dismiss
Pull typecast Messaging Proposition for getPropositionsForSurface API
This reverts commit 02461a4.
dsoffiantini
force-pushed
the
content-card-containers
branch
7 times, most recently
from
6997afe to
81521eb
Compare
dsoffiantini
force-pushed
the
content-card-containers
branch
from
81521eb to
00e7269
Compare
* Add unread UI implementation Add unread UI implementation * update the unread icon mock example update the unread icon mock example * Use useContainerSettigs hook Use useContainerSettigs hook and update the dist files * update unreadIcon for error handling update unreadIcon for error handling * Update with review comments Update with review comments * fix the building errors for sample app and update the sample app fix the building errors for sample app and update the sample app * update with review comments update with review comments * update for new comments update for the new comments * Update test Update test * Update metro.config and dist files Update metro.config and dist files * Update few UI color in the sample app Update few UI color in the sample app * update the code to automatically refetch the content card update the code to automatically refetch the content card * Revert "update the code to automatically refetch the content card" This reverts commit f8e1f1a. * update read status from native update read status from native * Add isRead to contentTemplate constructor Add isRead to contentTemplate constructor
* adding content card container ui component * removing console logs * removing templateType & capacity logic, fixing up styling * addressing PR feedback * more styling adjustments * removing trailing space * updating metro file * adding some basic unit tests for content card container + removing duplicate color scheme variable * removed unnecessary variable * fixing typing * addressing more pr feedback * renaming to CardProps --------- Co-authored-by: Julia Kartasheva <[email protected]>
* adding unit tests for content card components * removing unused value --------- Co-authored-by: Julia Kartasheva <[email protected]>
* adding content card container ui component * removing console logs * removing templateType & capacity logic, fixing up styling * addressing PR feedback * more styling adjustments * removing trailing space * updating metro file * adding some basic unit tests for content card container + removing duplicate color scheme variable * removed unnecessary variable * fixing typing * addressing more pr feedback * renaming to CardProps * adding capacity logic to content container * added chaining to the listener * adding back old app & track functionality * adding refetching & extraData --------- Co-authored-by: Julia Kartasheva <[email protected]>
fix error message for missing button in the content card
* adding content card container ui component * removing console logs * removing templateType & capacity logic, fixing up styling * addressing PR feedback * more styling adjustments * removing trailing space * updating metro file * adding some basic unit tests for content card container + removing duplicate color scheme variable * removed unnecessary variable * fixing typing * addressing more pr feedback * renaming to CardProps * adding capacity logic to content container * added chaining to the listener * adding back old app & track functionality * adding refetching & extraData * adding initial changes for test app updates * fixing up test app for android * adding staging cards * adding fixes for messagin error/picture problems in android --------- Co-authored-by: Julia Kartasheva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: