Skip to content

fix: Tabs vertical overflow wrapping #8602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

fix: Tabs vertical overflow wrapping #8602

merged 4 commits into from
Jul 22, 2025

Conversation

snowystinger
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 21, 2025

@devongovett
Copy link
Member

In Safari I get this:
image

@rspbot
Copy link

rspbot commented Jul 21, 2025

@rspbot
Copy link

rspbot commented Jul 21, 2025

@@ -57,7 +57,7 @@ OrientationVertical.story = {
name: 'orientation: vertical'
};

export const OrientationVerticalWrap: TabsStory = () => renderWithVerticalWrap({minWidth: 90, wrap: true});
export const OrientationVerticalWrap: TabsStory = () => renderWithVerticalWrap({wrap: true});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem like it's wrapping? or did we mean to update the name of this story

@rspbot
Copy link

rspbot commented Jul 22, 2025

@LFDanLu LFDanLu added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit f410099 Jul 22, 2025
32 of 33 checks passed
@LFDanLu LFDanLu deleted the fix-tabs-overflow branch July 22, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants