Skip to content

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Sep 4, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the CustomWidth story and confirm that it looks alright and the width is indeed custom. Also confirm that the other dialogs look alright. One thing to note is that you cannot mix the prop size with a custom width or else it will look funkyyy but I think that's fine since you probably wouldn't be using a default size if you want to use a custom width.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 4, 2025

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind running chromatic on this? Probably won't pick anything up since the change was just for allowing through an override but just in case

@yihuiliao yihuiliao added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 23e4a2d Sep 5, 2025
35 of 36 checks passed
@yihuiliao yihuiliao deleted the custom-dialog-width branch September 5, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants