Skip to content

Conversation

@snowystinger
Copy link
Member

Closes

Starting point for release notes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 24, 2025

@nwidynski

This comment was marked as outdated.

@snowystinger

This comment was marked as outdated.

@rspbot
Copy link

rspbot commented Oct 27, 2025

@rspbot
Copy link

rspbot commented Oct 27, 2025

@snowystinger snowystinger marked this pull request as ready for review October 27, 2025 04:49
@rspbot
Copy link

rspbot commented Oct 27, 2025

@rspbot
Copy link

rspbot commented Oct 27, 2025

@rspbot
Copy link

rspbot commented Oct 27, 2025

@yihuiliao
Copy link
Member

I think the overall structure looks good. Did we ever discuss if we want the contents of the S2 release notes to be structured like our old docs, or if we plan to leave it the same as what we had in storybook?

As for the RAC release notes, do we need to update the release notes to filter out any V3 changes (or did you already do that?)

reidbarber
reidbarber previously approved these changes Oct 27, 2025
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to have Breadcrumbs at the top of the release pages with a link back to the Releases page.

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to fix the links somehow

@devongovett
Copy link
Member

are we only including releases back to the start of RAC? what about ones before that?

reidbarber

This comment was marked as outdated.

@rspbot
Copy link

rspbot commented Oct 27, 2025

@rspbot
Copy link

rspbot commented Oct 28, 2025

@snowystinger
Copy link
Member Author

@devongovett

are we only including releases back to the start of RAC? what about ones before that?

My thoughts on this right now.
Hard break on release notes, start at 1.0 for RAC, start at 0.1 for S2

Anything before that will likely be filled with broken links etc, they should be preserved for the future though. I propose either keeping them in unused mdx files in our repo, or copying their contents to the appropriate GitHub release tag with a disclaimer that the urls may not link to the correct place or may just be broken.

# Conflicts:
#	packages/dev/s2-docs/src/CodeBlock.tsx
#	packages/dev/s2-docs/src/Layout.tsx
@rspbot
Copy link

rspbot commented Oct 28, 2025

@snowystinger
Copy link
Member Author

As for the RAC release notes, do we need to update the release notes to filter out any V3 changes (or did you already do that?)

I've done a light sweep, if you see anything obvious, feel free to point it out

@rspbot
Copy link

rspbot commented Oct 28, 2025

@rspbot
Copy link

rspbot commented Oct 28, 2025

reidbarber
reidbarber previously approved these changes Oct 28, 2025
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will go through the rest tomorrow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spacing in between the bullets is inconsistent. some sections they are spaced more tightly than others

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have an example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

you can see how in the section above the bullet points it looks single spaced whereas fixes section looks double spaced

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if there was a chevron left at the top so that you can easily get back to the release page rather than having to click on it in the side nav

# Conflicts:
#	packages/dev/s2-docs/src/Code.tsx
#	packages/dev/s2-docs/src/CodeBlock.tsx
@rspbot
Copy link

rspbot commented Oct 30, 2025

@rspbot
Copy link

rspbot commented Oct 30, 2025

@rspbot
Copy link

rspbot commented Oct 30, 2025

@rspbot
Copy link

rspbot commented Oct 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants