Skip to content

Conversation

@snowystinger
Copy link
Member

Closes

This changes from the popover to a true dialog for touch devices where a keyboard may come into view and mess with the scroll position.
It removes the intermediate ref from the examples and uses the form submission to track updated values.
Adds aria labels and better label examples.
Removes inverted row hover color.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger changed the title fix EditableTable Cells from testing feedback fix: EditableTable Cells from testing feedback Oct 29, 2025
@rspbot
Copy link

rspbot commented Oct 29, 2025

@rspbot
Copy link

rspbot commented Oct 29, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:EditableCell

 EditableCell {
   align?: 'start' | 'center' | 'end' = 'start'
   children: ReactNode
   colSpan?: number
   id?: Key
   isSaving?: boolean
-  onSubmit: () => void
+  onSubmit: (Record<string, any>) => void
   renderEditing: () => ReactNode
   showDivider?: boolean
   textValue?: string
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants