-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: Refactor Style Macro reference table to disclosures #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…kgroundColor felt like it looks better because all the values map directly to the disclosure values
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice if the first disclosure is default open within each sub level
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@snowystinger yep, what do we think about that case? I opted to keep as is since it is consistent with the following: aka the full value mapping is listed and then the definition of each non-standard value follows below. I could special case these ones perhaps but would it look weird if it some were missing that "value" heading but others were? |
|
I just don't know what the first baseSpacing vs the second baseSpacing is, why is it there twice? it don't see that in the minHeight screen shot you're showing? |
|
@snowystinger so the layout is roughly this: In my screenshot, which of these would be preferable? OR---------------------
or the original? |
reidbarber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better!
|
I think I prefer the second one, so it still says Values, but when there's only one, it omits the need to repeat it for the definition |




✅ Pull Request Checklist:
📝 Test Instructions:
Go to the Style Macro reference page via https://reactspectrum.blob.core.windows.net/reactspectrum/87d20590345a208e4837e8a63277a2821a764d5f/s2-docs/s2/style-macro.html and make sure the values for each of the properties still display. Feedback on experience welcome as well, especially for the updated Colors, Dimensions, and Text sections
🧢 Your Project:
RSP