Skip to content

Introduce NixOS support (download proper kustomize binary) #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce NixOS support (download proper kustomize binary) #55

wants to merge 1 commit into from

Conversation

@AleksanderGondek
Copy link
Contributor

@AleksanderGondek AleksanderGondek commented Feb 2, 2021 •
edited
Loading

Related Issue

Implements feature request 54

Motivation and Context

Allow rules_gitops to work on NixOS without any additional patching.

How Has This Been Tested?

I have been running similar patch for quite time on my NixOS-based machines.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AleksanderGondek AleksanderGondek requested a review from a team as a code owner February 2, 2021 16:46
@kzadorozhny kzadorozhny mentioned this pull request Feb 2, 2021
Open
kzadorozhny
kzadorozhny requested changes Feb 2, 2021
View reviewed changes
Copy link
Member

@kzadorozhny kzadorozhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Requires #56

  • Requires e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzadorozhny kzadorozhny kzadorozhny requested changes

+1 more reviewer

@vahan-sahakyan-op vahan-sahakyan-op vahan-sahakyan-op approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AleksanderGondek @kzadorozhny @vahan-sahakyan-op