fix(dialog): revert close event timing to dispatch immediately [BREAKING CHANGE]

[Rajdeepc]

Description

This PR reverts the breaking change introduced in SWC 1.0.3 PR #4937 that moved the close event dispatch from immediate to post-animation completion. The change was causing issues for applications that rely on immediate close event handling, such as route changes and state cleanup.

Problem

The previous change in PR #4937 moved the close event to fire after animations complete, which:

• Breaks applications expecting immediate event handling
• Prevents route changes from happening when users click close
• Delays state cleanup and navigation preparation

Solution

Revert the close event timing to dispatch immediately when dialog.close() is called, while maintaining proper animation coordination through the existing sp-closed event from the overlay system.

Changes Made

• DialogBase.ts:
  • Modified close() method to dispatch close event immediately
  • Removed post-animation close event dispatch from update() method
  • Cleaned up unused methods (dispatchClosed, hasTransitionDuration)

Breaking Change

This is a breaking change that reverts the previous breaking change from SWC 1.0.3. Applications that were updated to work with the delayed close event timing will need to be updated to handle immediate close events again.

Related issue(s)

• Reverts changes from PR fix(dialog): fade-out animation when lazy loaded on popover overlays #4937
• Fixes issues with Quick Actions dialogs and other applications requiring immediate close event handling

Screenshots (if appropriate)

---

Author's checklist

• I have read the CONTRIBUTING and PULL_REQUESTS documents.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
• I have added automated tests to cover my changes.
• I have included a well-written changeset if my change needs to be published.
• I have included updated documentation if my change required it.

---

Reviewer's checklist

• Includes a Github Issue with appropriate flag or Jira ticket number without a link
• Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
• Automated tests cover all use cases and follow best practices for writing
• Validated on all supported browsers
• All VRTs are approved before the author can update Golden Hash

Manual review test cases

• Descriptive Test Statement

  1. Go here
  2. Do this action
  3. Expect this result

• Descriptive Test Statement

  1. Go here
  2. Do this action
  3. Expect this result

Device review

• Did it pass in Desktop?
• Did it pass in (emulated) Mobile?
• Did it pass in (emulated) iPad?

[changeset-bot]

⚠️ No Changeset found

Latest commit: 711eedb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

📚 Branch Preview

• Documentation Site
• Storybook

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• Spectrum | Light | Medium | LTR
• Spectrum | Dark | Large | RTL
• Express | Light | Medium | LTR
• Express | Dark | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Dark | Large | RTL
• High Contrast Mode | Medium | LTR

Deployed to Azure Blob Storage: pr-5633

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

[github-actions]

Tachometer results

Currently, no packages are changed by this PR...