MWPW-170589: POC Loading Unity after LCP

[joaquinrivero]

Description

This PR defers the loading of the Unity block and its libraries until after LCP event is completed. The goal is to reduce render-blocking resources during initial load and improve Core Web Vitals, specifically LCP

Related Issue

Resolves: MWPW-170589

Test URLs

• http://main--dc--adobecom.hlx.page/acrobat/online/sign-pdf
• http://mwpw-170589--dc--adobecom.hlx.page/acrobat/online/test/verb-widget-lcp

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 122d0c5 ✅ (latest)
• e65dfeb ✅
• 595e12d ✅
• 88cc3b6 ✅
• 60e5874 ✅
• adbd90c ✅

[Copilot]

Pull Request Overview

This PR introduces a proof-of-concept for loading the Unity block and its dependencies after the Largest Contentful Paint (LCP) event to optimize page performance.

• Added a new function to create and load a Unity block within the verb widget.
• Updated the analyticsLoad event listener to call the new function in both LCP and fallback branches.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 1.35135% with 73 lines in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (ee9e9c5) to head (122d0c5).

Files with missing lines	Patch %	Lines
acrobat/blocks/verb-widget/verb-widget.js	1.40%	70 Missing ⚠️
acrobat/blocks/unity/unity.js	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #1076      +/-   ##
==========================================
- Coverage   73.87%   73.64%   -0.23%     
==========================================
  Files          51       51              
  Lines        7732     7756      +24     
==========================================
  Hits         5712     5712              
- Misses       2020     2044      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

acrobat/blocks/verb-widget/verb-widget.js:463

• Consider awaiting loadUnityAfterLCP() to handle potential errors unless fire-and-forget execution is intentional.

loadUnityAfterLCP();

acrobat/blocks/verb-widget/verb-widget.js:468

• Consider awaiting loadUnityAfterLCP() to ensure any errors during Unity block loading are caught, unless non-blocking behavior is desired.

loadUnityAfterLCP();

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

---

🚫 [eslint] <object-curly-spacing> _{reported by reviewdog 🐶}
A space is required after '{'.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 801 in adbd90c

if(canSendDataToSplunk) window.analytics.sendAnalyticsToSplunk(event, VERB, {...metadata, errorData}, getSplunkEndpoint());

---

🚫 [eslint] <object-curly-spacing> _{reported by reviewdog 🐶}
A space is required before '}'.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 801 in adbd90c

if(canSendDataToSplunk) window.analytics.sendAnalyticsToSplunk(event, VERB, {...metadata, errorData}, getSplunkEndpoint());

---

🚫 [eslint] <no-use-before-define> _{reported by reviewdog 🐶}
'getSplunkEndpoint' was used before it was defined.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 801 in adbd90c

if(canSendDataToSplunk) window.analytics.sendAnalyticsToSplunk(event, VERB, {...metadata, errorData}, getSplunkEndpoint());

---

🚫 [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 6 spaces but found 4.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 831 in adbd90c

? 'https://unity.adobe.io/api/v1/log'

---

🚫 [eslint] <indent> _{reported by reviewdog 🐶}
Expected indentation of 6 spaces but found 4.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 832 in adbd90c

: 'https://unity-stage.adobe.io/api/v1/log';

---

🚫 [eslint] <no-trailing-spaces> _{reported by reviewdog 🐶}
Trailing spaces not allowed.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 832 in adbd90c

: 'https://unity-stage.adobe.io/api/v1/log';

---

🚫 [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 108. Maximum allowed is 100.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 835 in adbd90c

function handleAnalyticsEvent(eventName, metadata, documentUnloading = true, canSendDataToSplunk = true) {

---

🚫 [eslint] <keyword-spacing> _{reported by reviewdog 🐶}
Expected space(s) after "if".

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 837 in adbd90c

if(!canSendDataToSplunk) return;

---

🚫 [eslint] <no-multi-spaces> _{reported by reviewdog 🐶}
Multiple spaces found before 'return'.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 837 in adbd90c

if(!canSendDataToSplunk) return;

---

🚫 [eslint] <no-shadow> _{reported by reviewdog 🐶}
'userAttempts' is already declared in the upper scope on line 491 column 9.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 845 in adbd90c

function handleUploadingEvent(data, userAttempts, cookieExp, canSendDataToSplunk) {

---

🚫 [eslint] <no-shadow> _{reported by reviewdog 🐶}
'userAttempts' is already declared in the upper scope on line 491 column 9.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 858 in adbd90c

function handleUploadedEvent(data, userAttempts, cookieExp, canSendDataToSplunk) {

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

---

🚫 [eslint] <no-shadow> _{reported by reviewdog 🐶}
'userAttempts' is already declared in the upper scope on line 491 column 9.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 858 in adbd90c

function handleUploadedEvent(data, userAttempts, cookieExp, canSendDataToSplunk) {