Skip to content

MWPW-170897: Unordered list action for rte-field #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2025
Merged

Conversation

st-angelo-adobe
Copy link
Collaborator

@st-angelo-adobe st-angelo-adobe commented Apr 4, 2025

Copy link

aem-code-sync bot commented Apr 4, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 4, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@3ch023
Copy link
Collaborator

3ch023 commented Apr 8, 2025

@st-angelo-adobe you can provide https://mwpw-170897--mas--adobecom.aem.live/ instead of https://mwpw-170897--mas--adobecom.aem.live/studio.html in Before/After PR description. this will ensure psi green

@mirafedas mirafedas self-requested a review April 8, 2025 13:32
@npeltier
Copy link
Collaborator

npeltier commented Apr 8, 2025

pro tip @st-angelo-adobe to get green psi check, compare root of the domain, not /studio :-)

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-170897 April 9, 2025 07:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-170897 April 9, 2025 08:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-170897 April 9, 2025 08:18 Inactive
@Roycethan
Copy link
Collaborator

@st-angelo-adobe Was not able to remove the list by clicking back the option - is this authoring ability not needed ?
Example of this can be found in this Git editor , (Edit and click on the below - test )

  • test
image

@st-angelo-adobe
Copy link
Collaborator Author

@Roycethan I implemented your suggestion.
I'll just say that there may be some niche scenarios where the behavior of the list action might not be exactly what we want (as in, sometimes you get two consecutive lists instead of merging them). But this is the default behaviors of these actions in prosemirror, I've checked with some demo implementations too, and they all behave the same.

If we want some refinements we could do that separately.
cc: @npeltier @3ch023 @yesil

@Roycethan
Copy link
Collaborator

MWPW-170897

Thanks, fixed

@Roycethan Roycethan merged commit 121a9e2 into main Apr 11, 2025
6 checks passed
@Roycethan Roycethan deleted the MWPW-170897 branch April 11, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants