-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-170623] - iframe video control fix #3892
base: stage
Are you sure you want to change the base?
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be in draft?
@media (min-width: 1790px) { | ||
.milo-video, | ||
.milo-iframe { | ||
padding-bottom: 47.25%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I almost wonder if adjusting the min-width
on line 27 would be more straight forward and predictable.
Yes, yesterday at the end of the day after I put up the PR, Ratko noticed that this story may be a duplicate of one that he is doing, it seems that his PR also fixes this so I put it in draft mode until we communicate this through Milo-Core, but in all likelihood we will need only his PR. Ratko's PR - #3881 |
This resolves the issue where at around 1790px and onward screen width, the iframe controls start going down behind the scene where the user can't see or interact with them.
Resolves: MWPW-170623
Test URLs: