Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-170623] - iframe video control fix #3892

Draft
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

DKos95
Copy link
Contributor

@DKos95 DKos95 commented Apr 1, 2025

This resolves the issue where at around 1790px and onward screen width, the iframe controls start going down behind the scene where the user can't see or interact with them.

Resolves: MWPW-170623

Test URLs:

@DKos95 DKos95 requested a review from a team April 1, 2025 15:50
Copy link
Contributor

aem-code-sync bot commented Apr 1, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Apr 1, 2025

@DKos95 DKos95 marked this pull request as draft April 1, 2025 16:14
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be in draft?

@media (min-width: 1790px) {
.milo-video,
.milo-iframe {
padding-bottom: 47.25%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost wonder if adjusting the min-width on line 27 would be more straight forward and predictable.

@DKos95
Copy link
Contributor Author

DKos95 commented Apr 2, 2025

Is this supposed to be in draft?

Yes, yesterday at the end of the day after I put up the PR, Ratko noticed that this story may be a duplicate of one that he is doing, it seems that his PR also fixes this so I put it in draft mode until we communicate this through Milo-Core, but in all likelihood we will need only his PR.

Ratko's PR - #3881
My Page with Ratko's solution - https://mwpw-170384-lost-info-320--milo--adobecom.hlx.page/drafts/dusan/iframe-video-control-overflow#test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants