[Tabs] Center/Right alignment changes lockup alignment #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
mokimo
approved these changes
Apr 7, 2025
overmyheadandbody
approved these changes
Apr 7, 2025
|
Reminder to set the |
SilviuLCF
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-169844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tabsorsection-metadatathat use thecenterorrightvariantsContext
Original issue called out the editorial block used inside of tabs. There are additional blocks impacted by this issue upon further investigation. See below for outline of those blocks.
The lockup feature does have it's own alignment settings that are applied at it's block level. Those settings should not be impacted by this fix.
Additional impacts discovered
Other blocks impacted by this that use lockups
Section-metadata also has a
centervariant that can impact lockup alignment with the following blocks:Resolves: MWPW-169844
Test URLs:
DC Test URLs:
Test URLs include all affected blocks mentioned above: