Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dynamic PR template for Gnav components #3901

Merged
merged 7 commits into from
Apr 8, 2025
Merged

Conversation

bandana147
Copy link
Contributor

@bandana147 bandana147 commented Apr 4, 2025

  • Including Gnav and footer's variants in the test Urls for all clients if the PR touches any files under these 2 folders:
libs/blocks/global-navigation/**
libs/blocks/global-footer/**

Resolves: MWPW-170257

Test URLs:

PR generated using this template - #3903

Copy link
Contributor

aem-code-sync bot commented Apr 4, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Apr 4, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to gnav-dynamic-pr April 4, 2025 08:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to gnav-dynamic-pr April 4, 2025 08:24 Inactive
@mokimo
Copy link
Contributor

mokimo commented Apr 4, 2025

@overmyheadandbody @narcis-radu @robert-bogos wdyt, should we have this for every PR with more general pages?
See the template in action #3903

Having a well constructed PR template seems tremendously useful beyond gnav PRs

Copy link
Contributor

github-actions bot commented Apr 5, 2025

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@aem-code-sync aem-code-sync bot temporarily deployed to gnav-dynamic-pr April 8, 2025 08:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to gnav-dynamic-pr April 8, 2025 09:07 Inactive
@overmyheadandbody
Copy link
Contributor

Yes, @mokimo, I love it! We had the approach of using the query param, but this is much better, also considering that a lot of contributors don't want to invest too much time in writing the PR description. We shouldn't have a 1:1 with the Gnav template, though. I'll open a story for us to look into

@spadmasa
Copy link

spadmasa commented Apr 8, 2025

Validated sample urls provided
https://jira.corp.adobe.com/browse/MWPW-170257

@spadmasa spadmasa added the verified PR has been E2E tested by a reviewer label Apr 8, 2025
@milo-pr-merge milo-pr-merge bot merged commit 2a056ec into stage Apr 8, 2025
20 checks passed
@milo-pr-merge milo-pr-merge bot deleted the gnav-dynamic-pr branch April 8, 2025 11:30
@milo-pr-merge milo-pr-merge bot mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants