-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dynamic PR template for Gnav components #3901
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
@overmyheadandbody @narcis-radu @robert-bogos wdyt, should we have this for every PR with more general pages? Having a well constructed PR template seems tremendously useful beyond gnav PRs |
Reminder to set the |
Yes, @mokimo, I love it! We had the approach of using the query param, but this is much better, also considering that a lot of contributors don't want to invest too much time in writing the PR description. We shouldn't have a 1:1 with the Gnav template, though. I'll open a story for us to look into |
27a63fe
to
26fa665
Compare
Validated sample urls provided |
Resolves: MWPW-170257
Test URLs:
PR generated using this template - #3903