Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external sub target dist to upper level as a common target #5939

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

sophia-guo
Copy link
Contributor

Update to copy generated dockerfile as a condition to check external tests SHAs.

Close #5825

Signed-off-by: Sophia Guo <[email protected]>
Also remove unused targets

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo marked this pull request as draft February 3, 2025 20:14
@sophia-guo sophia-guo marked this pull request as ready for review February 3, 2025 21:20
@sophia-guo
Copy link
Contributor Author

Changes are common to all externals. @LongyuZhang could you please double check if it is good with CRIU tests?

@sophia-guo sophia-guo force-pushed the external branch 2 times, most recently from dc63101 to 39fba56 Compare February 3, 2025 21:32
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CRIU container test passed too (hyc_grinder 47374)

@LongyuZhang LongyuZhang requested a review from llxia February 4, 2025 15:00
@sophia-guo sophia-guo merged commit 062a1dc into adoptium:master Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

track external test sha
3 participants