-
-
Notifications
You must be signed in to change notification settings - Fork 322
Update job status based on parallel and rerun job status #6185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sophia Guo <[email protected]>
Signed-off-by: Sophia Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that overall we have a state machine here. Might be worth taking a 1,000 foot step back and rethinking how this is designed / coded with that in mind.
buildenv/jenkins/JenkinsfileBase
Outdated
@@ -1427,7 +1427,8 @@ def generateJob (newJobs, childTest, testJobName) { | |||
* - rerun due to test job in FAILURE state - RERUN_FAILURE is true and rerunTestJobParams cannot be empty | |||
* If the JOB_NAME contains _rerun, _testList_ or _iteration_, rerun job will not be triggered at the same level. | |||
*/ | |||
def triggerRerunJob (rerunTestJobParams) { | |||
//rerunTestJobParams should be part of return of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment seems cut off?
buildenv/jenkins/JenkinsfileBase
Outdated
def rerunResults = archiveChildJobTap(childJobs, originalStatus) | ||
currentBuild.result = rerunResults.jobStatus | ||
} else { | ||
echo " Either all rerun succeed or there are aborted?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't quite parse for me
It's certainly a little complex.. but i'd rather take that point as a new "issue". This PR is essential to be able to determine jck success for public users who do not have access to tck......... |
I am going to add some documentation / table in the original issue to help clarify the expected behaviour in the various cases. |
Signed-off-by: Sophia Guo <[email protected]>
Signed-off-by: Sophia Guo <[email protected]>
Close #6000