trapme: Clarify JDK_REPO / USE_TESTENV_PROPERTIES relationship #6734
+21
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TESTENV_PROPERTIES is turned off Signed-off-by: Stewart X Addison <[email protected]>
…TIES relationship Signed-off-by: Stewart X Addison <[email protected]>
Member
Author
|
I've reformatted the the table in the doc to make sure everything lines up, which does mean I get "credit" for more lines than I've really modified in terms of content in the blame history in this file, but it was upsetting me. I can revert that if anyone has a strong feeling the other way ;-) |
smlambert
reviewed
Nov 19, 2025
smlambert
reviewed
Nov 19, 2025
Contributor
smlambert
left a comment
smlambert
left a comment
There was a problem hiding this comment.
These repos are also 'pinned' in the testenv.properties file.
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Co-authored-by: Shelley Lambert <[email protected]>
Co-authored-by: Shelley Lambert <[email protected]>
Co-authored-by: Shelley Lambert <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
karianna
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note to the description of the JDK_REPO/JDK_BRANCH (and OpenJ9 equivalent) fields in the test jobs to make it clear that the USE_TESTENV_PROPERTIES parameter needs to be false/unchecked (it defaults to true) for them to take effect
Ref: Slack discussion