-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds support for Keycloak 26.1 #1256
feat: Adds support for Keycloak 26.1 #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. , the issue on the ci seems to not be feasible, as we are also experiencing the same failure for those keycloak versions. I would appreciate it if you could look into the root cause.
For the lint-other-files step, ubuntu-latest jumped to ubuntu-24 which did not support python 3.7, you can pin the version to ubuntu-22.04
Hi @AssahBismarkabah, |
9cb1421
to
274b35a
Compare
@maximilian-krauss I also noticed that too, but the error below occurs locally using kc-26.1 at
|
Yes, I also can reproduce the ImportAuthenticationFlowsIT failure, but only if I run it the whole suite via maven. If I execute them via IntelliJ they work just fine |
On my side it also fails when just running the Lines 762 to 764 in 1e3badb
Why should we find two configs for the same alias? |
Hey @antikalk, |
The |
would be enough |
The Then the test is no longer correct |
c877a80
to
faf2b32
Compare
Hey @bohmber, thanks for pointing that out. I updated the tests and they are passing now. Seems reasonable why the behavior changed. Cheers, |
@maximilian-krauss can you merge the latest changes from main into your branch? |
faf2b32
to
3952910
Compare
Quality Gate passedIssues Measures |
Hey @bohmber, done 🙂 |
I tested these code changes with our configuration and keycloak 26.1 without problems. @AssahBismarkabah can you review the changes, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine on my end as well @bohmber, thanks @maximilian-krauss .
@AssahBismarkabah is there an ETA on when a KC 26.1 compatible release will be available? :) |
Hi @antikalk, we are currently working on that. The release will be available before the end of today. Thanks! |
What this PR does / why we need it:
Adds support for Keycloak 26.1.
Which issue this PR fixes: fixes #1253
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR