Skip to content

Potential fix for code scanning alert no. 1: Server-side request forgery #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 1: Server-side request forgery #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Frontend/el7a2ny-frontend/src/components/CheckoutForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ export default function CheckoutForm({ appointmentId, patientUsername, packageNa
const [message, setMessage] = useState(null);
const [isLoading, setIsLoading] = useState(false);

const route = appointmentId ? `appointments/${appointmentId}` : `health-packages/${packageName}`;
const validAppointmentId = /^[a-zA-Z0-9_-]+$/.test(appointmentId) ? appointmentId : null;
const validPackageName = /^[a-zA-Z0-9_-]+$/.test(packageName) ? packageName : null;
const route = validAppointmentId ? `appointments/${validAppointmentId}` : validPackageName ? `health-packages/${validPackageName}` : null;

useEffect(() => {
if (!stripe) return;
Expand Down Expand Up @@ -46,6 +48,9 @@ export default function CheckoutForm({ appointmentId, patientUsername, packageNa
setIsLoading(true);

try {
if (!/^[a-zA-Z0-9_-]+$/.test(patientUsername) || !route) {
throw new Error("Invalid input detected.");
}
await axios.post(`${BACKEND_ROUTE}/patients/${patientUsername}/payment/${route}`, {
paymentMethod: "Wallet",
});
Expand Down Expand Up @@ -78,6 +83,9 @@ export default function CheckoutForm({ appointmentId, patientUsername, packageNa
}
if (paymentIntent && paymentIntent.status === "succeeded") {
try {
if (!/^[a-zA-Z0-9_-]+$/.test(patientUsername) || !route) {
throw new Error("Invalid input detected.");
}
await axios.post(`${BACKEND_ROUTE}/patients/${patientUsername}/payment/${route}`, {
paymentMethod: "Card",
});
Expand Down