yannik_and_jonas #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edited code to fulfill minimum requirements
* edited assertions * Edited commenting and docstrings
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
ArkayHub
reviewed
Aug 4, 2021
fixed links of screenshots
…step, fixed a bug in the subplot creation when using a single walker and replaced pythons round() function with maths ceil function to correctly round the number of subplots up
* Introduced classes for different walker behaviours, added type annotation, revised comments and docstrings, added plotting of start- and endpoint as well as a legend * Renamed classes and reformatted * Reformatted some comments * added running Walker and flying walker to the script and renamed some variables for better understanding Co-authored-by: Yannik <[email protected]> * implemented functions to get starting and ending positions instead of writing them mandatorily * reformatted docstrings and removed repeating code * fixed bug in step calculation and added marker definitions for plots * added assert statement * added figtext for flying walkers * first draft of a landscape implementation * moved functions into class * implemented all necessary functions into walker class, adjusted way of calculating path * moved user input check into create_walker function and fixed typos * added filling to building in plot * added files with tests for the walker script * fixed typo and removed temporary input definition * resort imports and fixed typo * introduced outfile_name variable instead of writing it directly * added improved try-except-statement * removed fixed dpi setting * changed a walking speed description to casually * updateed readme * update files which where deleted/newly created * added dependency numbers * fixed typo Co-authored-by: Yannik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.